-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cygwin: workaround DLL load address conflict #22696
Conversation
For me, the failure occurs only with |
isnt a global rebase of libperl and all XS DLLs supposed to run in Cygwin? |
It would be anything that makes the binaries larger, I reproduced it with |
The DLL load addresses are generated by the linker based on the DLL names, and 5.39.10 we're getting a conflict between cygperl5_41_6.dll and Langinfo.dll. As a workaround, statically link Langinfo into cygperl for CI and mention the problem in perldelta for anyone else who might build perl on cygwin Fixes but should not close Perl#22695
8712262
to
2626bf6
Compare
That isn't what that says, and isn't what it does.
Also, it only runs for 32-bit builds, which cygwin no longer support, which I can understand, since DLL conflicts like this were many times more common there. |
I've added a note on this. |
Can someone familiar with Cygwin review this p.r.? (I'd like to quiet our CI failures on that platform.) Thanks. |
@tonycoz, this did close #22695; should you re-open it? (My impression is that our Cygwin CI builds are still failing.) |
Thanks github, reopened.
blead is passing, see the green tick at the top of https://github.com/Perl/perl5 and you can see green ticks for the CI runs done since this was merged at https://github.com/Perl/perl5/commits/blead/ Any PRs will need to be rebased on blead to pass. |
The DLL load addresses are generated by the linker based on the DLL names, and 5.39.10 we're getting a conflict between cygperl5_41_6.dll and Langinfo.dll.
As a workaround, statically link Langinfo into cygperl for CI and mention the problem in perldelta for anyone else who might build perl on cygwin
Fixes but should not close #22695
TODO: fill description here