From 7e243859c47e07fc918e0944f2a8e9eb907824f2 Mon Sep 17 00:00:00 2001 From: "Jason A. Crome" Date: Mon, 18 Dec 2023 18:34:45 -0500 Subject: [PATCH 1/4] Fix typo in subtest name --- t/logger.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/logger.t b/t/logger.t index e45a5949d..4cc5b9e3a 100644 --- a/t/logger.t +++ b/t/logger.t @@ -63,7 +63,7 @@ subtest 'log level and capture' => sub { is_deeply $trap->read, []; }; -subtest 'logger enging hooks' => sub { +subtest 'logger engine hooks' => sub { # before hook can change log level or message. hook 'engine.logger.before' => sub { my $logger = shift; # @_ = ( $level, @message_args ) From 8eb7e83515390ac5b9a59366953b44f5b2115dab Mon Sep 17 00:00:00 2001 From: "Jason A. Crome" Date: Mon, 18 Dec 2023 18:35:05 -0500 Subject: [PATCH 2/4] Document logger formatting code for app name --- lib/Dancer2/Core/Role/Logger.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/Dancer2/Core/Role/Logger.pm b/lib/Dancer2/Core/Role/Logger.pm index 3b49a828d..b260f42ab 100644 --- a/lib/Dancer2/Core/Role/Logger.pm +++ b/lib/Dancer2/Core/Role/Logger.pm @@ -242,6 +242,10 @@ The possible values are: =over 4 +=item %a + +app name + =item %h host emitting the request From 0e83b4a50bc06bfddb870e8ae99e70915a2d66a4 Mon Sep 17 00:00:00 2001 From: "Jason A. Crome" Date: Tue, 2 Jan 2024 14:41:01 -0500 Subject: [PATCH 3/4] Document hooks for logging engine --- lib/Dancer2/Manual.pod | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/lib/Dancer2/Manual.pod b/lib/Dancer2/Manual.pod index 42b095251..30f0b4f46 100644 --- a/lib/Dancer2/Manual.pod +++ b/lib/Dancer2/Manual.pod @@ -682,6 +682,35 @@ for details on the following hooks: =back +=head2 Logging + +Logging hooks do not allow you to alter log message content, but they do +give you a place to perform extra actions. For example, if you want to send +an email for error messages, but you don't want to use a heavier logger +such as L or L: + + hook 'engine.logger.after' => sub { + my ( $logger, $level, $message ) = @_; + + if( $level eq 'error' ) { + # Send an email with the message content + } + }; + +There are two hooks available for logging: + +=over 4 + +=item * engine.logger.before + +This hook is called before a log message is produced. + +=item * engine.logger.after + +This hook is called after a log message is produced. + +=back + =head2 Serializers =over 4 From 1be14662ff1792b6432fc07783c6525c677245c4 Mon Sep 17 00:00:00 2001 From: "Jason A. Crome" Date: Tue, 2 Jan 2024 21:10:09 -0500 Subject: [PATCH 4/4] reflect changes --- Changes | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Changes b/Changes index 18147ce44..8e1bacfaa 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,21 @@ {{$NEXT}} + [ BUG FIXES ] + * None + + [ ENHANCEMENTS ] + * GH #33: Named routes; add uri_for_route keyword (Sawyer X) + + [ DOCUMENTATION ] + * PR #1706: Document missing logging hooks and log format option; + fix typo in logging test (Jason A. Crome) + + [ DEPRECATED ] + * None + + [ MISC ] + * None + 1.1.0 2023-12-11 20:28:26-05:00 America/New_York [ BUG FIXES ]