Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell fill from a lower row overlapping onto top hline #4

Open
PgBiel opened this issue Apr 12, 2023 · 4 comments
Open

Cell fill from a lower row overlapping onto top hline #4

PgBiel opened this issue Apr 12, 2023 · 4 comments
Assignees
Labels
bug Something isn't working renderer Related to the final rendering (drawing) step of the table.
Milestone

Comments

@PgBiel
Copy link
Owner

PgBiel commented Apr 12, 2023

Generating smaller hlines than normal (missing the bottom half of the stroke).

image

@PgBiel PgBiel added the bug Something isn't working label Apr 12, 2023
@PgBiel PgBiel self-assigned this Apr 12, 2023
@PgBiel PgBiel added this to the v0.0.2 milestone Apr 12, 2023
@PgBiel
Copy link
Owner Author

PgBiel commented Apr 16, 2023

This might require #2 for a proper solution.

@PgBiel PgBiel modified the milestones: v0.0.2, v0.1.0 May 1, 2023
@PgBiel PgBiel added the renderer Related to the final rendering (drawing) step of the table. label Nov 17, 2023
@Fabioni
Copy link
Sponsor

Fabioni commented Dec 17, 2023

This really needs to get fixed. Without fill is not useable.

@Fabioni
Copy link
Sponsor

Fabioni commented Dec 18, 2023

I found a workaround. Having a 0cm row that spans all columns and a 0cm column that spans all rows fixes the issue.

This looks correct:

#tablex(
    fill: luma(240),
    columns: (0cm, 1fr, 1fr),
    rowspanx(3)[], [?], [?],
    (), [?], [?], 
    (), [?], [?], 
)

but this does not:

#tablex(
    fill: luma(240),
    columns: (0cm, 1fr, 1fr),
    (), [?], [?],
    (), [?], [?], 
    (), [?], [?], 
)

@PgBiel
Copy link
Owner Author

PgBiel commented Dec 18, 2023

Yep, that will work (as will setting header-rows to a really high value) because it will force tablex to draw all of your cells at the same time (instead of drawing per row / rowspan), drawing cells first and then lines, which circumvents this problem. However, that will make it impossible to split your table across pages.

I plan on tackling this on 0.1.0 by providing a new renderer which will draw per page instead of per row, which is how native tables do it, but I haven't gotten to it yet (I also haven't yet experimented with the idea to know how much of it is possible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working renderer Related to the final rendering (drawing) step of the table.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants