Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not pass Entity explode event #42

Open
DrkMatr1984 opened this issue Feb 6, 2017 · 4 comments
Open

Could not pass Entity explode event #42

DrkMatr1984 opened this issue Feb 6, 2017 · 4 comments

Comments

@DrkMatr1984
Copy link
Contributor

http://pastebin.com/bzvg78zd
on TnT explode

06.02 03:34:14 [Server] INFO Caused by: java.lang.NoClassDefFoundError: eu/phiwa/dragontravel/nms/v1_8_R3/RyeDragon

Seems we need to implement some sort of reflection here to prevent this error in the future.
I've implemented a temporary workaround for this issue by first checking if the entity exploding is an instanceof EnderDragon.

@Phiwa
Copy link
Owner

Phiwa commented Feb 6, 2017

Thanks for the fix, the problem never occured for me since I never used TNT while testing DT... ;)

@Phiwa Phiwa closed this as completed Feb 6, 2017
@DrkMatr1984
Copy link
Contributor Author

DrkMatr1984 commented Feb 6, 2017

I figured. If you're not exploding much, the entity explode event would never get called. :) I believe in order to have this work with versions other than 1.8 R3 we'll have to implement reflection instead of importing RyeDragon from eu.phiwa.dragontravel.nms.v1_8_R3.RyeDragon outright.

@Phiwa
Copy link
Owner

Phiwa commented Feb 6, 2017

Yes, I saw it already. I guess, that will be included in a third "nms-specific" class...
Maybe it is a good idea to reopen this issue to keep track of the process.

@Phiwa Phiwa reopened this Feb 6, 2017
@DrkMatr1984
Copy link
Contributor Author

Yeah, keep it open for now. One of us will get to it soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants