Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player dismount height #60

Closed
wants to merge 2 commits into from
Closed

Player dismount height #60

wants to merge 2 commits into from

Conversation

mhtvsSFrpHdE
Copy link

fixed #53

Important:

// Fix player got fall damage by temporary subtract 5 from station height
// TODO: We need to discuss about how to better fix this in future
// Replace dragon by other mob can make this fix invalid and get player killed
// This will only happen if station recorded above height 5

Phiwa
Phiwa requested changes Sep 17, 2019
View reviewed changes
Copy link
Owner

@Phiwa Phiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add .vscode to the .gitignore.
I'd like to keep the repository free of artifacts caused by an IDE to keep it IDE-independent.

Phiwa
Phiwa requested changes Sep 17, 2019
View reviewed changes
Copy link
Owner

@Phiwa Phiwa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do not like this workaround.
This isn't the right place to fix it since it means that we need to implement it another time for flights.

A solution for the problem should be implemented in the method dealing with dismounting which is the method getSafeLandingLoc in class DragonManager or alternatively in one of the methods above that one in the stack (depending on how the solution looks like, e.g. "temporary damage immunity" or similar).

@mhtvsSFrpHdE mhtvsSFrpHdE deleted the player-dismount-height branch September 22, 2019 18:55
@mhtvsSFrpHdE
Copy link
Author

mhtvsSFrpHdE commented Sep 22, 2019 •
edited
Loading

@Phiwa Like I said in the issue, I try multiple method to avoid that damage but none of them can work without "modify" the destination position y axis.
The "getSafeLandingLoc" should, and did work to report correct safe landing height.
But it didn't be used properly in the next few step and caused fall earlier even if the value is corrent.
(Or the safe landing operation have issue instead of safe landing height)
I can't identify the issue between "destination" and "safeLandingLoc"
and why safe landing can't work.

@mhtvsSFrpHdE
Copy link
Author

Should we just use "destination hack" to make it effective globally,
or find a better safe landing operation sequence?

@mhtvsSFrpHdE
Copy link
Author

Certainly a better safe landing logic is good.
Let's do something.

@Phiwa
Copy link
Owner

Phiwa commented Sep 22, 2019 •
edited
Loading

That's the reason why this issue still isn't fixed.
One could argue that we should get a workaround out now while we are working on a better solution, but to be honest, this would mean that the issue is never tackled again since there is no visible issue anymore.
Let's try to find a better solution now. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phiwa Phiwa Phiwa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Player got fall damage when reach the station
2 participants
@mhtvsSFrpHdE @Phiwa