Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering on match and team tables. #139

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

PhlexPlexico
Copy link
Owner

No description provided.

@PhlexPlexico PhlexPlexico merged commit 1994dcb into master May 9, 2022
@PhlexPlexico PhlexPlexico deleted the table-load-fixes branch May 9, 2022 15:41
@PhlexPlexico
Copy link
Owner Author

Hey @kubo6472,

This merge should now fix the issues with the tables. Make sure you update the API as well!

Thanks!

@PhlexPlexico PhlexPlexico self-assigned this May 9, 2022
@kubo6472
Copy link
Contributor

kubo6472 commented May 9, 2022

image

@kubo6472
Copy link
Contributor

kubo6472 commented May 9, 2022

image
phew

@PhlexPlexico
Copy link
Owner Author

PhlexPlexico commented May 9, 2022

Were those actually forfeit wins? I'm not sure why undefined is showing that as my live DB snapshot is working as intended, at least.

E: Also as I said, make sure you update the API as well if you haven't done so already.

@kubo6472
Copy link
Contributor

kubo6472 commented May 9, 2022

Were those actually forfeit wins? I'm not sure why undefined is showing that as my live DB snapshot is working as intended, at least.

E: Also as I said, make sure you update the API as well if you haven't done so already.

Nope, just that this happens when restoring the db on docker compose. Dunno what might've caused this, but I haven't had this problem b4.

@PhlexPlexico
Copy link
Owner Author

This is mainly due to the fact the queries have changed for the gets for both teams and matches. Instead of making an additional API call to get the string (Live, won, lost, etc), it calculates it on the front-end now, by retrieving match and map scores. If there are no scores (i.e. team1_score and team2_score in the match table, and team1_score team2_score in the map stats table if BO1), then it will most likely show undefined. I would make sure your data is making it across properly into the DB, because as it stands I am able to see everything correctly (as observed on phlex.avidgamers.me) when the data is in a correct format. Even my other instance that is running on docker is showing everything as correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants