Added DockerfileLightCaddy & Fixed the Caddyfile #90
Conversation
Update to include vertigo/ancient pictures.
|
I am still relatively new to Caddy as well, but my setup was following the setup I had in the wiki for single domains, since this container will only be running one domain. Have you tested the |
|
Oh! Speaking of, and looking back at the branch you wish to merge into - I now remember the problem that I ran into with Caddy! Since Caddy requires variables for reverse proxy, nostname, and the API endpoint at build time, there is no possible way for this to be created into a package like the NGINX version! That's the one main issue I had when looking into this. However, we can still merge it in, but just know that it won't be at all possible to have this in a docker-compose file due to this issue! Thanks! |
Caddyfile
Outdated
| uri strip_prefix /API_END_POINT | ||
| reverse_proxy {$CADDY_PROXY_URL} | ||
| {$CADDY_URL} { | ||
| handle_path /{$CADDY_API_ENDPOINT}* { |
There was a problem hiding this comment.
Also, the api endpoint path isn't needed in this Caddyfile since it's not acting as the reverse proxy, so these API paths will have to be removed.
There was a problem hiding this comment.
To basically respond to all is just that this is the setup I am currently running with no 404s. It's covering the whole stack with a single webserver basically.
There was a problem hiding this comment.
Just so I'm getting this right you mean "one" webserver being the main reverse proxy (in your case I assume Caddy?) that would be setup independent from all projects (excluding the new docker-compose file)? If so, that's good to know! Then I am willing to accept the changes but please make sure to not include the reverse proxy directives in this file as it is not needed inside the container, it should be pushed up one level :) I think you should be able to remove all variables in this file as well, as I've done in the branch you are merging into. If you just rebase onto that and make the merge conflict fixes I should be able to merge both in. Please note that I'm only doing a light file, as a full file should not be needed, and I would like to move away from that as well.
There was a problem hiding this comment.
The light file is my choice all the way, everytime. The levels was what I was avoiding. It's this weird hybrid setup of three containers: mariadb, g5api and g5v that provides the dist files and a webserver+reverse proxy all in that third one. I did some experiments assemling it into a compose file, but not successfully, yet. You can think of it as a very monolithic deployment. But very easy for basic setups.
There was a problem hiding this comment.
I mean, if you want an easy setup you should be able to use this one just fine, and it uses Caddy as the reverse proxy https://github.com/PhlexPlexico/G5API/blob/master/docker-compose.yml
But yeah, I think we're on the same page then. It's just cutting down to semantics and I guess if someone wants to roll everything with Caddy, I suppose it should be allowed (even though it doesn't really make any difference at this level). Once resolved, I can merge everything in. Just make sure the Caddyfile stays similar to the changes that were recently made (i.e. no build variables needed) and it should be good to merge :)
PhlexPlexico
force-pushed
the
docker-caddy
branch
from
1721191 to
f397f83
Compare
DockerfileFullCaddy
Outdated
| @@ -0,0 +1,28 @@ | |||
| FROM caddy:2.4.6-alpine | |||
There was a problem hiding this comment.
So yeah, delete this file please
README.md
Outdated
| @@ -57,6 +57,32 @@ Now, you can run your application by running ```docker container run --name g5v | |||
| G5V requires G5API to be running at `/api`, you can change this behavior run `docker build -t yourname\g5v:latest -f DockerfileFull --build-arg VUE_APP_G5V_API_URL=<your_api_url>` (be sure to include `http(s)://` and not to have a trailing `/`). If you are using Docker Compose refer to [this](https://docs.docker.com/compose/compose-file/compose-file-v3/#args). | |||
| Some example setup configs can be found [here](https://github.com/PhlexPlexico/G5V/wiki). | |||
|
|
|||
| #### DockerfileFullCaddy: | |||
There was a problem hiding this comment.
Just make sure the readme doesn't get changed too much either - a rebase should fix these :)
|
Updated the readme to fix the change issue and the Caddyfile to reflect your changes, just delete the dockerfilefullcaddy and we should be good to merge in! |
|
you got it :)
|
No description provided.