Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device instances should know their controllers #709

Closed
uweseimet opened this issue Feb 26, 2022 · 0 comments · Fixed by #806
Closed

Device instances should know their controllers #709

uweseimet opened this issue Feb 26, 2022 · 0 comments · Fixed by #806
Assignees
@uweseimet
Labels
architecture Software architecture and code quality

Comments

@uweseimet
Copy link
Contributor

uweseimet commented Feb 26, 2022 •
edited
Loading

Currently with any SCSI command to execute a device gets passed its controller instance. It is probably better if each instance of a device knew its controller, so that the interface between devices and controllers can be simplified. The respective field should be in the PrimaryDevice class.
For some time it may be useful to have two fields, one for the SASI and one for the SCSI controller.

#660 will most likely have to be done first.
@uweseimet uweseimet added the enhancement New feature or request label Feb 26, 2022
@uweseimet uweseimet mentioned this issue Feb 26, 2022
Closed
@uweseimet uweseimet linked a pull request Aug 23, 2022 that will close this issue
SASI code removal, error handling update, bug fixes, code cleanup #806
Merged
@uweseimet uweseimet added architecture Software architecture and code quality and removed enhancement New feature or request labels Aug 27, 2022
@uweseimet uweseimet self-assigned this Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uweseimet uweseimet

Labels
architecture Software architecture and code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SASI code removal, error handling update, bug fixes, code cleanup PiSCSI/piscsi
1 participant
@uweseimet