From 3a48bf5cf4f8f51b77b31c9d4484ee4cac0b696c Mon Sep 17 00:00:00 2001 From: wuhuizuo Date: Tue, 10 Sep 2024 09:16:17 +0000 Subject: [PATCH 1/3] fix(charts/prow): adjust the probes Signed-off-by: wuhuizuo --- charts/prow/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/prow/Chart.yaml b/charts/prow/Chart.yaml index 88a2da9b0..bad7ef1fe 100644 --- a/charts/prow/Chart.yaml +++ b/charts/prow/Chart.yaml @@ -21,7 +21,7 @@ type: application # time you make changes to the chart and its templates, # including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: "0.9.9" +version: "0.9.10" # This is the version number of the application being deployed. # This version number should be incremented each time you make changes to the From fbc3df6f6d753dc178de486231e4d6d1151af590 Mon Sep 17 00:00:00 2001 From: wuhuizuo Date: Tue, 10 Sep 2024 09:32:23 +0000 Subject: [PATCH 2/3] fix(charts/prow): adjust probes for tide Signed-off-by: wuhuizuo --- charts/prow/templates/components/tide/deployment.yaml | 6 +++--- charts/prow/values.yaml | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/charts/prow/templates/components/tide/deployment.yaml b/charts/prow/templates/components/tide/deployment.yaml index 09ec9a089..6bbcaf004 100644 --- a/charts/prow/templates/components/tide/deployment.yaml +++ b/charts/prow/templates/components/tide/deployment.yaml @@ -84,16 +84,16 @@ spec: httpGet: path: /healthz port: http - initialDelaySeconds: 30 + initialDelaySeconds: 60 periodSeconds: 30 - timeoutSeconds: 5 + timeoutSeconds: 10 readinessProbe: httpGet: path: /healthz/ready port: http initialDelaySeconds: 60 periodSeconds: 30 - timeoutSeconds: 5 + timeoutSeconds: 10 resources: {{- toYaml .Values.tide.resources | nindent 12 }} volumes: diff --git a/charts/prow/values.yaml b/charts/prow/values.yaml index 10c458e81..e15386871 100644 --- a/charts/prow/values.yaml +++ b/charts/prow/values.yaml @@ -393,6 +393,12 @@ tide: create: true name: "" resources: {} + # requests: + # cpu: 1000m + # memory: 4Gi + # limits: + # cpu: 1000m + # memory: 4Gi kubeconfigSecret: "" pipeline: From d6dfa106de3726e9dacb9fda7fc6c7e9764c0549 Mon Sep 17 00:00:00 2001 From: wuhuizuo Date: Tue, 10 Sep 2024 09:57:25 +0000 Subject: [PATCH 3/3] fix(charts/prow): add startup probe Signed-off-by: wuhuizuo --- charts/prow/templates/components/tide/deployment.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/charts/prow/templates/components/tide/deployment.yaml b/charts/prow/templates/components/tide/deployment.yaml index 6bbcaf004..d54adbd48 100644 --- a/charts/prow/templates/components/tide/deployment.yaml +++ b/charts/prow/templates/components/tide/deployment.yaml @@ -80,6 +80,13 @@ spec: name: kubeconfig readOnly: true {{- end }} + startupProbe: + httpGet: + path: /healthz + port: http + initialDelaySeconds: 60 + periodSeconds: 10 + failureThreshold: 60 livenessProbe: httpGet: path: /healthz