-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace hashids (bashids) with sqids #20
Comments
Will this cause any issues (dupes etc.) to be sent via RSS after the change? |
yeah, it will cause dupes. I ended up ripping the bandaid off and doing this on my own a blog a couple years back: https://paul.af/breaking-rss-feed-changes it's used like this right now: https://github.com/Pinjasaur/bic-example/blob/e4ef0ef54f175c4abc05e74f81e93277f49dc148/__feed.rss#L4-L5 here's the spec for here's the current implementation of
it's imperfect, but I was intentional about doing it this way to still allow for changing the filename e.g. I don't have a better idea on handling it offhand. thoughts @mfossen? |
technically, could go with the bare number prefix e.g. |
https://sqids.org/bash
this'll be a breaking change because the IDs (used in the RSS feed) will change, but it'll also simply it all slightly by removing the
SALT
envarThe text was updated successfully, but these errors were encountered: