Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch testHdBasicDrawing unit test to non-Qt? #103

Closed
meshula opened this issue Nov 4, 2016 · 5 comments
Closed

Switch testHdBasicDrawing unit test to non-Qt? #103

meshula opened this issue Nov 4, 2016 · 5 comments

Comments

@meshula
Copy link
Member

meshula commented Nov 4, 2016 •
edited
Loading

It would be great if the UsdImaging, Hd and Hdx unit tests were built against GLFW, or simply garch. Presently testHdBasicDrawing still requires a Qt C++ linkage:

if (QT4_FOUND)
pxr_build_test(testHdBasicDrawing
LIBRARIES
hd
glf
glfq
Qt4::QtCore
Qt4::QtOpenGL
CPPFILES
unitTestGLDrawing.cpp
testenv/testHdBasicDrawing.cpp
)
endif()
@c64kernal
Copy link
Contributor

Thanks Nick! This has already been fixed and will coming soon to a dev branch near you!

@jtran56
Copy link

jtran56 commented Nov 5, 2016

Filed as internal issue #139698.

@meshula
Copy link
Member Author

meshula commented Nov 5, 2016

Heh, that is super fine :)

@takahito-tejima
Copy link
Contributor

it's already in dev.
22c321d#diff-a3d976811ef2a4b0180955e2aff0c1a4

@meshula
Copy link
Member Author

meshula commented Nov 8, 2016

Ah thank! My fork was out of date.

@Felix-Kit Felix-Kit mentioned this issue Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@meshula @takahito-tejima @c64kernal @jtran56