Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect material tag detection for OpenPBR surface #3172

Open
JGamache-autodesk opened this issue Jul 18, 2024 · 1 comment
Open

Incorrect material tag detection for OpenPBR surface #3172

JGamache-autodesk opened this issue Jul 18, 2024 · 1 comment

Comments

@JGamache-autodesk
Copy link
Contributor

Description of Issue

The material tag detection code added in #3073 had some forward looking code for OpenPBR that requires an update, even though we have not yet integrated MaterialX 1.39.

When I first wrote the code, the geometry_opacity parameter was a GfVec3. In the final specification, it is now a float. That is a one line change to do in _GetOpenPBRSurfaceMaterialTag() when integrating MaterialX 1.39, replacing GfVec3f(1.0f, 1.0f, 1.0f) with 1.0f.

Steps to Reproduce

  1. None yet. Requires MaterialX 1.39 to get an OpenPBR surface node

System Information (OS, Hardware)

Package Versions

Build Flags

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants