Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BlockVariantSelection to VariantSets #1319

Closed
chrisrydalch opened this issue Sep 10, 2020 · 4 comments
Closed

Add BlockVariantSelection to VariantSets #1319

chrisrydalch opened this issue Sep 10, 2020 · 4 comments

Comments

@chrisrydalch
Copy link
Contributor

There is currently no API to set a VariantSet's Selection to be an empty string, in order to effectively block weaker variant selections. Both SetVariantSelection() and ClearVariantSelection() usd the same Sdf APIs, which interpret an empty string as nothing, and don't author any specs into the layer.

After a discussion on usd-interest, adding a request for a BlockVariantSelection() method.

Thanks!
@jtran56
Copy link

jtran56 commented Sep 12, 2020

Filed as internal issue #USD-6336

@chrisrydalch
Copy link
Contributor Author

chrisrydalch commented Sep 19, 2020 •
edited
Loading

screenshot-area-2020-09-10-004635

BTW, we'll have a PR for this, probably some time this coming week.

Thanks!

@chrisrydalch chrisrydalch mentioned this issue Sep 25, 2020
Closed
@sunyab
Copy link
Contributor

sunyab commented Nov 6, 2020

PR #1340 was merged in commit fff8462 in the dev branch, marking as pending release.

@tallytalwar
Copy link
Contributor

Thanks, this was included in the 21.02 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tallytalwar @sunyab @jtran56 @chrisrydalch