Fix python wrappers to be explicit for RTLD_GLOBAL environments. #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently ran into some problems with the Python bindings to USD. Our Python configuration uses RTLD_GLOBAL for legacy reasons. The problem with this is that multiple USD projects contain functions with the same name. For example, there are multiple "wrapRegistry()" and "wrapNode()" functions defined in various places. We were seeing problems where, for example, ndr's module wrap function ended up calling sdr's wrapRegistry() instead of ndr's, and ndr's wrapRegistry() was never called. This led to various runtime errors. Our workaround was to rename wrapRegistry() in sdr as "wrapSdrRegistry()", for example, and use TF_WRAP(SdrRegistry) in the module wrapper. We made a handful of changes like this to make all the wrap calls explicit. This change makes all python wrappers uniquely named.
|
Filed as internal issue #USD-4800. |
pixar-oss
pushed a commit
that referenced
this pull request
Oct 25, 2018
These wrapping functions are an implementation detail and do not need to be exported from the Python module. This also avoids issues when wrapping functions from different libraries have the same name and Python is set to load modules using RTLD_GLOBAL. Also update some old documentation. Addresses #641 (Internal change: 1903686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently ran into some problems with the Python bindings to USD. Our Python configuration uses RTLD_GLOBAL for legacy reasons.
The problem with this is that multiple USD projects contain functions with the same name. For example, there are multiple "wrapRegistry()" and "wrapNode()" functions defined in various places. We were seeing problems where, for example, ndr's module wrap function ended up calling sdr's wrapRegistry() instead of ndr's, and ndr's wrapRegistry() was never called. This led to various runtime errors. Our workaround was to rename wrapRegistry() in sdr as "wrapSdrRegistry()", for example, and use TF_WRAP(SdrRegistry) in the module wrapper. We made a handful of changes like this to make all the wrap calls explicit.
Description of Change(s)
This change makes all python wrappers uniquely named.
Fixes Issue(s)