Fix a bug in UdsGeomImageable::MakeVisible #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting of the visibility attribute to "inherited" would only be done to the invisible ancestor prim closest to the root. If other ancestors were also marked as invisible (redundantly, but legally) the original prim would not end up being visible.
|
Filed as internal issue #USD-5713 |
|
Thank you for catching and fixing this, @marktucker ! Looks great - the test imports could be cleaned up; I think all you really need is Usd, UsdGeom, and unittest ? |
|
Thanks guys! I'll take care of cleaning up the imports in the test (THANK YOU for adding a test!). |
pixar-oss
added a commit
that referenced
this pull request
Dec 9, 2019
Fix a bug in UdsGeomImageable::MakeVisible (Internal change: 2027610)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in UdsGeomImageable::MakeVisible, in which the recursive setting
of the visibility attribute to "inherited" would only be done to the invisible
ancestor prim closest to the root. If other ancestors were also marked as
invisible (redundantly, but legally) the original prim would not end up
being visible.
Description of Change(s)
Reversed the order of a conditional inside the recursive _MakeVisible function so
that the setting of the visibility attribute to "inherited" on ancestors is not short
circuited after the first ancestor has this attribute changed.
Fixes Issue(s)
The provided test case will fail without this change. The prim will not be visible
after calling MakeVisible on it.