Fix extent computation plugins for simple primitive types (sphere/cube/cone/etc) #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etching attribute values from the primitive. Otherwise the default value for the attribute would always be used. Implementations for other primitive types already use the timecode this way.
|
Filed as internal issue #USD-6273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extent computation functions for these basic primitive types were not passing
the time argument to the UsdAttribute.Get calls.
Description of Change(s)
Use the timecode argument passed to extent computation plugins when fetching
attribute values from the primitive. Otherwise the default value for the
attribute would always be used. Implementations for other primitive types
already use the timecode this way.