A collection of fixes for Windows path handling, especially involving symlinks #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmed
directory paths on Windows ("/c:/foo/bar.usd"). Just add a simple check for
the infinite recursion rather than trying to figure out and avoid conditions
that might lead to it.
… raise an exception if this function is passed a non-canonical Windows path.
A symlink can specify either an absolute or relative path. This change adds a check for the "relative" flag, and converts the symlink path to a full path, since that's what callers to this function assume will be returned.
Tests absolute paths without drive latters, relative paths, and some more challenging symlink tests, including resolving symlinks while inside a symlink directory.
|
Filed as internal issue #USD-6591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This started as an attempt to fix a possible exception when handling paths starting with "/" in the code for #1441 and then write some additional tests. But my test cases kept failing. Turns out there were still issues in handling on non-mountpoint symlinks on Windows. There was also the potential for infinite recursion in Tf_MakeDirsRec when it was passed a malformed path.
Also adding the test cases that were failing without all these fixes.
Relates to #1441, #1378.