Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: Fix for dome light not changing #2125

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Dec 7, 2022

Description of Change(s)

If the dome light texture was changed then the lighting system wouldn't pick it up until another file was selected.

Fixes Issue(s)

  • Dome light not changing.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@creijon
Copy link
Contributor Author

creijon commented Dec 9, 2022

@klucknav I think I've got this right, can you take a look at it?

@sunyab
Copy link
Contributor

sunyab commented Dec 9, 2022

Filed as internal issue #USD-7821

@klucknav
Copy link
Contributor

I think you have this right as well, Thank you!

@creijon creijon force-pushed the jon/dev/fix_dome_light_not_changing branch from 5bcc807 to 6d31cda Compare December 10, 2022 07:36
@pixar-oss pixar-oss merged commit 3592bac into PixarAnimationStudios:dev Jan 4, 2023
@creijon creijon deleted the jon/dev/fix_dome_light_not_changing branch January 5, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants