Fix GetDisplayName() for Anonymous Layers. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #158778. |
sunyab
requested changes
Apr 20, 2018
There was a problem hiding this comment.
Hey @superfunc, I think this change seems fine, but iI think the test case should be in Sdf itself. Could you add a test case in testSdfLayer.py as well? Thanks!
|
Yeah I'll get that up tonight ✌️ |
sunyab
added
blocked
superfunc
force-pushed
the
sdf_layer_display_name_fix
branch
from
0b17a06
to
930accb
Compare
|
Ok, I just moved the test over to sdf, should be good to merge now. |
sunyab
requested changes
Apr 27, 2018
| return std::string(); | ||
| // We want to find the second occurence of ':', traversing from the left, | ||
| // in our identifier which is of the form anon:0x4rfs23:displayName | ||
| auto fst = std::find(identifier.begin(), identifier.end(), ':'); |
There was a problem hiding this comment.
Can we bail here if fst == identifier.end() for safety? The old code handled the case where there were no ":" characters in the identifier (even if this should never happen), so I think it'd be good to follow suit.
There was a problem hiding this comment.
Done, updated. Thanks :)
It was broken when the provided identifier had a colon in it, which is legal in a posix file path.
This behavior fundamentally lives in sdf, so it should be tested there. UsdStage's constructors just forward into this code.
superfunc
force-pushed
the
sdf_layer_display_name_fix
branch
from
930accb
to
e0d6867
Compare
sunyab
added
pending push
and removed
blocked
pixar-oss
added a commit
that referenced
this pull request
May 21, 2018
Fix GetDisplayName() for Anonymous Layers.
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…Controller. (PixarAnimationStudios#440) ### Description of Change(s) Move setting the camera and framing information in RenderIndex from UsdImagingGLEngine to taskController. This is because UsdImagingGLEngine may not be used by the client. But taskController is more widely used. Also add SetCameraFramingState function to RenderIndex. Sometimes there is no camera set when the renderindex syncs, so the user must set worldToViewMatrix, projection matrix and viewport to the renderindex directly. ### Fixes Issue(s) - <!-- Please follow the Contributing and Building guidelines to run tests against your change. Place an X in the box if tests are run and are all tests passing. --> - [ ] I have verified that all unit tests pass with the proposed changes <!-- Place an X in the box if you have submitted a signed Contributor License Agreement. A signed CLA must be received before pull requests can be merged. For instructions, see: http://openusd.org/release/contributing_to_usd.html --> - [ ] I have submitted a signed Contributor License Agreement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
It was broken when the provided identifier had a colon in it,
which is legal in a posix file path.
e.g.
Should return
foo:foo.usda, but currently returns an empty stringFixes Issue(s)