[Houdini] Test for a CH_Manager before calling CH_Manager functions. #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash when running ginfo on a USD file. ginfo does not create any node/channel infrastructure, so trying to call global CH_Manager methods leads to a crash.
|
Filed as internal issue #USD-4861. |
pixar-oss
added a commit
that referenced
this pull request
Oct 30, 2018
[Houdini] Test for a CH_Manager before calling CH_Manager functions. (Internal change: 1905368)
AdamFelt
pushed a commit
to autodesk-forks/USD
that referenced
this pull request
Apr 16, 2024
…hich is for divide the text run. (PixarAnimationStudios#674) ### Description of Change(s) Add the CommonTextGenericText::DivideTextRun function which is for divide the text run. Use this function in DivideTextRunByTabs, DivideTextRunByScripts and fontSubstitution. ### Fixes Issue(s) - <!-- Please follow the Contributing and Building guidelines to run tests against your change. Place an X in the box if tests are run and are all tests passing. --> - [ ] I have verified that all unit tests pass with the proposed changes <!-- Place an X in the box if you have submitted a signed Contributor License Agreement. A signed CLA must be received before pull requests can be merged. For instructions, see: http://openusd.org/release/contributing_to_usd.html --> - [ ] I have submitted a signed Contributor License Agreement (cherry picked from commit ef132b69e9d3ad0bc77c6b3e1c8ec6ef68180b9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash when running ginfo on a USD file. ginfo does not create
any node/channel infrastructure, so trying to call global CH_Manager methods
leads to a crash.
If no CH_Manager exists, use a default of "1" for the sample time.
This fixes Issue #673