New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring roadmap #80

Open

jordiae opened this issue Feb 19, 2021 · 0 comments

Contributor

jordiae commented Feb 19, 2021 •

edited

Loading

Migrate filters and transforms to filters.py and transforms.py, respectively. Import them in the different components.
Migrate argparse and __init__ to SimpleParsing (https://github.com/lebrice/SimpleParsing)
Rethink/re-organize components. Current suggestion: Parser, RawDocumentProcessor*, SentenceSplitter, SentenceProcessor, Dedup, Formatter
TBD etc

Document everything, not necessarily in any specific order.

*Sub-components (perhaps should be separate components):

RawDocMetadataFilter (discard by heads, URL, etc?)
RawDocStringTransform (raw string transformations, including, at first, encoding fixer, which is currently an independent component)
RawDocFilter (raw string filters)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment