Platzi Master Evaluation #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Here is my solution for the node evaluation.
A few comments:
I ran the API tests in postman and all of them works fine, but when I ran the command npm run test:e2e
I got errors on the Product list by category and deleteing a category, I think this is related to the test cases, since I see you are using the same port in bot cases.
Also seems that in the way, the tests delete all the cases in the database so the last 2 test in categories.e2e.js doesnt find a category neither products.
I just checked all the cases over and over.
Thank you