-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@gajaguar<Gerardo Antonio Gerónimo Vasconcelos> #62
Open
gajaguar
wants to merge
101
commits into
PlatziMaster:master
Choose a base branch
from
gajaguar:@gajaguar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create `build`. - Change `dev` to work with typescript. - Add `lint:js` to run `eslint`. - Add `lint` as shortcut of `lint:js`. - Change `start` to execute from `lib` directory. - Add `test` as shortcut of `test:e2e`.
Move the builder to `utils` directory and convert into a class.
Fix an error that cause that only the first registered resource endpoints works.
- Category - Product
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my solution for the pre cohort Platzi Master challenge.
I turn the project into typescript, it mean breaking changes on each comit, lol.
I try implement a little bit of SOLID principles. The test just breaks, no time for fix it.
My efforts were left in this project. I hope it be of your liking.