New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile only when object generation has changed #140

Closed

dgkanatsios opened this issue Jan 19, 2022 · 1 comment

Labels

Collaborator

dgkanatsios commented Jan 19, 2022 •

edited

Loading

We should examine if we can save some reconciles by running the loop only when the object generation has changed. Example: kubernetes-sigs/kubebuilder#618 (comment) and kubernetes-sigs/kubebuilder#618 (comment)

dgkanatsios added the enhancement label

Collaborator Author

dgkanatsios commented Jan 27, 2022

Closing since this

is not applicable to the GameServer controller, since .status can be changed externally (NodeAgent) and status change doesn't trigger a generation change (only a resource version change)
is not applicable to the GameServerBuild controller, since we need the reconciliation even if the Object Generation is the same while a child GameServer might have been updated

dgkanatsios closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment