Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kickoff | Clean Script throws ESLint errors #11

Closed
erwstout opened this issue Sep 2, 2021 · 3 comments · Fixed by #16
Closed

Kickoff | Clean Script throws ESLint errors #11

erwstout opened this issue Sep 2, 2021 · 3 comments · Fixed by #16
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@erwstout
Copy link
Contributor

erwstout commented Sep 2, 2021

After install, ESLint complains about imports in clean.js

image.png
@erwstout erwstout added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Sep 2, 2021
@erwstout
Copy link
Contributor Author

erwstout commented Sep 2, 2021

Adding /* eslint-disable @typescript-eslint/no-var-requires*/ to clean.js will fix the issue

@saurabhmehta1601
Copy link
Contributor

saurabhmehta1601 commented Sep 3, 2021 •
edited
Loading

This error is happening due to rule no-vars-requires which do not allow commonjs require-export syntax .You can know more about this rule from here.

It is better not to run @typescript-eslint/recommended plugin and react/recommended plugin on .js files but only on .ts and .tsx files .
You can do that using overrides in eslintconfig .

@saurabhmehta1601 saurabhmehta1601 mentioned this issue Sep 3, 2021
Merged
@erwstout
Copy link
Contributor Author

erwstout commented Sep 3, 2021

Great catch, thanks @saurabhmehta1601

erwstout pushed a commit that referenced this issue Sep 3, 2021
@saurabhmehta1601
fix(eslint): Add overrides to eslintrc.json, close #11
a1de127 
fix #11
github-actions bot pushed a commit that referenced this issue Sep 3, 2021
@semantic-release-bot
chore(release): 2.0.1-next.1 [skip ci]
eec7513 
## [2.0.1-next.1](v2.0.0...v2.0.1-next.1) (2021-09-03)

### Bug Fixes

* **eslint:** Add overrides to eslintrc.json, close [#11](#11) ([a1de127](a1de127))
github-actions bot pushed a commit that referenced this issue Sep 3, 2021
@semantic-release-bot
chore(release): 2.0.1 [skip ci]
eb343f8 
## [2.0.1](v2.0.0...v2.0.1) (2021-09-03)

### Bug Fixes

* **eslint:** Add overrides to eslintrc.json, close [#11](#11) ([a1de127](a1de127))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eslint): Add overrides to eslintrc.json, close #11
2 participants
@erwstout @saurabhmehta1601