Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - SSL/TLS Connections #1

Open
metalingusman opened this issue Aug 13, 2018 · 4 comments
Open

Feature Request - SSL/TLS Connections #1

metalingusman opened this issue Aug 13, 2018 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@metalingusman
Copy link

I would like to request a feature to enable aggregator to communicate over secure connections using certificates. This would help prevent network traffic from being profiled, manipulated, or disseminated while in-transit.

@spebern
Copy link
Contributor

spebern commented Aug 13, 2018

Implemented, would be nice if you could check it out.

@metalingusman
Copy link
Author

Wow! That was fast! I'll test it out shortly and let you know how it goes.

@metalingusman
Copy link
Author

I have attempted to test the TLS connection, but it does not appear to be working. Below is the command that I am running to listen on all addresses on port 6585 and to use publicly signed cert/key:

./aggregator --listen-address=0.0.0.0:6585 --submit-url=http://50-50-pool.burst.cryptoguru.org:8124 --cert-file=/etc/ssl/private/XXX.pem --key-file=/etc/ssl/private/XXX.key`

The app does seem to inspect the keypair properly because it will error out if I give it a bad key. When I give it the correct keypair it appears to be listening; however, scavenger returns "[WARN] error getting mining info". The scavenger config is as follows:

secret_phrase: 'MY INFO HERE'
account_id: MINNUMERICINFOHERE
plot_dirs:
  - 'D:\plots'
  - 'E:\plots'
  - 'F:\plots'
  - 'G:\plots'
  - 'H:\plots'
  - 'C:\plot1'
  - 'C:\plot2'
  - 'C:\plot3'
  - 'C:\plot4'
  - 'C:\plot5'
  - 'C:\plot6'
  - 'C:\plot7'
  - 'C:\plot8'
url: 'https://MYDOMAINHERE:6585'
worker_thread_count: 5
reader_thread_count: 3
nonces_per_cache: 65536               # default 65536
target_deadline: 10885484741537822773 # default u64::MAX
use_direct_io: true                   # default true
get_mining_info_interval: 3000        # default 3000ms
timeout: 5000                         # default 5000ms
wakeup_after: 240                     # default 240s
console_log_level: 'Info'             # default Info, Options (Off, Error, Warn, Info, Debug, Trace)
logfile_log_level: 'Warn'             # default Warn, Options (Off, Error, Warn, Info, Debug, Trace)
logfile_max_count: 10                 # maximum number of log files to keep
logfile_max_size : 20                 # maximum size per logfile in MiB

console_log_pattern: '{({d(%H:%M:%S)} [{l}]):16.16} {m}{n}'
logfile_log_pattern: '{({d(%Y-%m-%d %H:%M:%S)} [{l}]):26.26} {m}{n}'

If I do a netcat/telnet to the port in question, I seem to connect to the server, but it doesn't look like it is being processed. See the following screenshots as examples:

https://imgur.com/a/z8DlIM8

If you'd like for me to do anything specific, please let me know. Thanks!

@spebern
Copy link
Contributor

spebern commented Aug 15, 2018

Gonna test it myself this week, haven't found the time yet. Thanks for the data!

@JohnnyFFM JohnnyFFM added bug Something isn't working enhancement New feature or request labels Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants