GCS migration updates #87
Conversation
ahoneiser
force-pushed
the
gcloud-updates
branch
from
5f68c5b to
fd5d803
Compare
ahoneiser
force-pushed
the
gcloud-updates
branch
from
fd5d803 to
04e80dc
Compare
app/telemetry/handler.py
Outdated
There was a problem hiding this comment.
This file is used in a google cloud function, so adjusting it to have a configured network id I think would require changes on those separate deploy instructions. I think the default value on getting it if the environment variable doesn't exist would make it continue doing the same thing, but I'd also be fine with leaving this file unchanged since the proxy server itself doesn't use it.
https://github.com/Pocket/proxy-server/blob/main/README.md#telemetry-function are the directions that reference this file
There was a problem hiding this comment.
Good to know. Did the change here mostly to make tests happy. The NETWORK_ID var was originally hard-wired, it would still be the same now, but read ADZERK_NETWORK_ID if present, so shouldn't change the actual situation a lot.
No description provided.