Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleConsensusModelPlane::optimizeModelCoefficients error message unclear. #1809

Closed
rkeatin3 opened this issue Jan 26, 2017 · 2 comments
Closed

Comments

@rkeatin3
Copy link

My Environment

  • Operating System and version: Ubuntu 16.04.1
  • Compiler: GCC 5.4.0
  • PCL Version: 1.7.2

Current Behavior

pcl::SampleConsensusModelPlane::optimizeModelCoefficients prints Not enough inliers found to support a model (3)! Returning the same coefficients. when trying to optimize a plane model with 3 inliers.

Possible Solution

It makes sense to return if inliers.size() < 3 to avoid extra computation (as I assume the PCA approach will have the same plane coefficients as the initial calculation), but maybe the error could be more clear that a valid model was calculated from the inliers but couldn't be further refined.

@taketwo
Copy link
Member

taketwo commented Jan 27, 2017

Is this better?

@rkeatin3
Copy link
Author

I missed this a few days ago, but that looks good to me! I hope that will save someone else a bit of confusion in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants