Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor integration #2078

Closed
SergioRAgostinho opened this issue Nov 13, 2017 · 2 comments
Closed

Appveyor integration #2078

SergioRAgostinho opened this issue Nov 13, 2017 · 2 comments
Milestone

Comments

@SergioRAgostinho
Copy link
Member

I'm trying to get PCL to build on a Windows CI, through Appveyor. Since vcpkg was introduced, the effort to get this done seems considerably reduced, which drove my motivation to have another look at it.

This is what I have so far
https://github.com/SergioRAgostinho/pcl/blob/appveyor/.appveyor.yml

Here's the current results
https://ci.appveyor.com/project/SergioRAgostinho/pcl

It seems I'm going in the right direction, but my lack of a local Windows development environment is making it hard to understand what paths I need to feed to CMake in order to get this to work. Any help on this, would be much appreciated. @UnaNancyOwen since you actually wrote PCL's vcpkg port, I'm currently assuming you might be able to help me here.

Right now I just want it to compile something 😅 . CMake can't find Flann. I noticed it was able to find the vcpkg's installed eigen and flann was installed using the same method, so I assumed the problem is something else. I also noticed you patched our FindFLANN script for vcpkg https://github.com/Microsoft/vcpkg/blob/master/ports/pcl/find_flann.patch, hence my option to build shared libs.

Do I need to add all my installed packages to the path or something? Or is flann being deployed differently in vcpkg? Any ideas...anyone ?

@UnaNancyOwen
Copy link
Member

UnaNancyOwen commented Nov 13, 2017

These dependent libraries (Boost, FLANN, QHull) are generated with dynamic link libraries. (vcpkg default triplet is x86-windows. It is generate dynamic link library.)
Therefor, I think it need to set the following options when CMake configure of PCL.

cmake -DCMAKE_TOOLCHAIN_FILE=c:/tools/vcpkg/scripts/buildsystems/vcpkg.cmake -DPCL_SHARED_LIBS=ON -DPCL_BUILD_WITH_BOOST_DYNAMIC_LINKING_WIN32=ON -DPCL_BUILD_WITH_FLANN_DYNAMIC_LINKING_WIN32=ON ..

@SergioRAgostinho
Copy link
Member Author

👍 build completed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants