Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using Boost imported targets #2732

Closed
SunBlack opened this issue Dec 20, 2018 · 12 comments
Closed

Switch to using Boost imported targets #2732

SunBlack opened this issue Dec 20, 2018 · 12 comments

Comments

@SunBlack
Copy link
Contributor

Imported targets of Boost requires CMake 3.5. Ubuntu 16.04 has CMake 3.5.1, so it is okay, to raise minimum required CMake version?

@taketwo
Copy link
Member

taketwo commented Dec 20, 2018

I'm fine with such a change, but would like to hear other opinions as well.

@jasjuang
Copy link
Contributor

I am ok with raising the minimum required cmake version.

@taketwo
Copy link
Member

taketwo commented Jan 18, 2019

@SergioRAgostinho are you also fine?

@SergioRAgostinho
Copy link
Member

Yup. I was just waiting on having the reason to do it. This is what I had to do last time I did a bump #2605.

@taketwo
Copy link
Member

taketwo commented Jul 4, 2019

We require 3.5 now.

@taketwo taketwo changed the title Imported targets of Boost requires CMake 3.5 Switch to using Boost imported targets Jul 4, 2019
@taketwo taketwo removed the kind: proposal Type of issue label Jul 4, 2019
@SergioRAgostinho
Copy link
Member

We are already at 3.5. fc9ffa1

@alokpr
Copy link

alokpr commented Nov 20, 2019

Please also do not disable the config mode by setting Boost_NO_BOOST_CMAKE=ON:

set(Boost_NO_BOOST_CMAKE ON)

This makes cmake super-project setting inconvenient where the embedding project builds both - boost and pcl. Is there a particular reason for explicitly disabling the config mode for Boost?

@SergioRAgostinho
Copy link
Member

da8c840

The commit message (from 2012)

disable the config mode of find_package(Boost) as it's not stable yet

It's a remnant of the past that never got updated.

@stale
Copy link

stale bot commented May 19, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the status: stale label May 19, 2020
@kunaltyagi
Copy link
Member

tagging @shrijitsingh99

@stale stale bot removed the status: stale label May 24, 2020
@stale
Copy link

stale bot commented Jun 23, 2020

Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs.

@mvieth
Copy link
Member

mvieth commented Jan 4, 2022

Closed by #4952

@mvieth mvieth closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants