-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using Boost imported targets #2732
Comments
I'm fine with such a change, but would like to hear other opinions as well. |
I am ok with raising the minimum required cmake version. |
@SergioRAgostinho are you also fine? |
Yup. I was just waiting on having the reason to do it. This is what I had to do last time I did a bump #2605. |
We require 3.5 now. |
We are already at 3.5. fc9ffa1 |
Please also do not disable the config mode by setting Boost_NO_BOOST_CMAKE=ON: pcl/cmake/pcl_find_boost.cmake Line 23 in 49ca041
This makes cmake super-project setting inconvenient where the embedding project builds both - boost and pcl. Is there a particular reason for explicitly disabling the config mode for Boost? |
The commit message (from 2012)
It's a remnant of the past that never got updated. |
Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs. |
tagging @shrijitsingh99 |
Marking this as stale due to 30 days of inactivity. It will be closed in 7 days if no further activity occurs. |
Closed by #4952 |
Imported targets of Boost requires CMake 3.5. Ubuntu 16.04 has CMake 3.5.1, so it is okay, to raise minimum required CMake version?
The text was updated successfully, but these errors were encountered: