Getters in SampleConsensus should have const qualifiers

[PPokorski]

Your Environment

• PCL Version: master branch

Context

Some methods in SampleConsensus class.

pcl/sample_consensus/include/pcl/sample_consensus/sac.h

Lines 142 to 143 in d009887

	inline double
	getDistanceThreshold () { return (threshold_); }

pcl/sample_consensus/include/pcl/sample_consensus/sac.h

Lines 152 to 153 in d009887

	inline int
	getMaxIterations () { return (max_iterations_); }

pcl/sample_consensus/include/pcl/sample_consensus/sac.h

Lines 163 to 164 in d009887

	inline double
	getProbability () { return (probability_); }

Expected Behavior

Those methods should be marked as const.

Current Behavior

const qualifier is not present.

Code to Reproduce

I think examples above are enough :)

Possible Solution

Add const qualifier.

[SergioRAgostinho]

Agreed. Feel free to open a PR with the changes.

[PPokorski]

Thank you. One more thing from MaximumLikelihoodSampleConsensus: there are some methods like those:

pcl/sample_consensus/include/pcl/sample_consensus/mlesac.h

Lines 124 to 127 in d009887

	double
	computeMedianAbsoluteDeviation (const PointCloudConstPtr &cloud,
	const boost::shared_ptr <std::vector<int> > &indices,
	double sigma);

pcl/sample_consensus/include/pcl/sample_consensus/mlesac.h

Lines 135 to 139 in d009887

	void
	getMinMax (const PointCloudConstPtr &cloud,
	const boost::shared_ptr <std::vector<int> > &indices,
	Eigen::Vector4f &min_p,
	Eigen::Vector4f &max_p);

pcl/sample_consensus/include/pcl/sample_consensus/mlesac.h

Lines 146 to 149 in d009887

	void
	computeMedian (const PointCloudConstPtr &cloud,
	const boost::shared_ptr <std::vector<int> > &indices,
	Eigen::Vector4f &median);

which, I think, could also be const. What do you think?

[taketwo]

Sure, these are good candidates to be marked const as well.