-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compile error] test_outofcore doesn't compile #4033
Comments
After switching to old revisions: Build is broken since #3750 is merged into master. |
That's very weird. Could you give more info on why the switch causes the errors? |
Not really - that's why I posted it as issue and didn't just submitted a PR - my hope was someone might have an idea ;-) |
This issue isn't present for GCC? Or did our CI fail to catch it? |
GCC8 on the same machine:
This CI seems to not have trouble:
|
Hmmm... #3750 (comment) is false again then. It's part of the messy #3753 migration to have a single switch for weak pointers. The weak pointer is most definitely a Is it really a problem with the braces maybe, like it was some other time? |
I absolutely hadn't read the OP and focused on the last message, apologies for my haste. |
@SunBlack Can you reproduce this in a docker? Did you get this error even after a clean rebuild? (PS: if you use ccache, please don't use ccache for one clean rebuild and try again) |
@docker: Currently not, but I use on my VM the same instructions like in the docker image (still with ubuntu 19.10), just a newer clang and additionally dependency to have a full build. And currently docker doesn't like me . So I can't really compare until now. @ReBuild: I deleted the build directory of Clang 10 and cleaned the ccache-Cache - nevertheless I'm getting the same error. GCC 8 with cleaned build directory & disabled CCache in CMake is still in progress. |
General question related to docker: Is the docker script in the repo here still correct? I'm building it via And then inside the image:
Result:
|
We have the env docker CI up and running. Based on that, I'd say yes
Are you using GCC? or Clang? CMake configuration (and the make command that fails Did you try using |
Yep my config
Log
With 16.04 I don't have trouble. |
|
As you can see I don't set any environment, so I think it should be gcc (interesting that CMake doesn't say anything, which compiler is selected). |
Now locally without disabled ccache & cleaned build dir:
Docker-Image:
|
I have the same problem.How to slove it? |
The linked pull request should fix the problem. Please try again with a newer PCL version (1.11.1 or current master branch). |
After I updated my master I currently getting this with Clang 10:
The text was updated successfully, but these errors were encountered: