diff --git a/registration/include/pcl/registration/exceptions.h b/registration/include/pcl/registration/exceptions.h index 327202edd8e..85fb8b29b76 100644 --- a/registration/include/pcl/registration/exceptions.h +++ b/registration/include/pcl/registration/exceptions.h @@ -52,8 +52,8 @@ namespace pcl public: SolverDidntConvergeException (const std::string& error_description, - const char* file_name = NULL, - const char* function_name = NULL, + const char* file_name = nullptr, + const char* function_name = nullptr, unsigned line_number = 0) : pcl::PCLException (error_description, file_name, function_name, line_number) { } } ; @@ -67,8 +67,8 @@ namespace pcl public: NotEnoughPointsException (const std::string& error_description, - const char* file_name = NULL, - const char* function_name = NULL, + const char* file_name = nullptr, + const char* function_name = nullptr, unsigned line_number = 0) : pcl::PCLException (error_description, file_name, function_name, line_number) { } } ; diff --git a/registration/include/pcl/registration/impl/ia_fpcs.hpp b/registration/include/pcl/registration/impl/ia_fpcs.hpp index 1190a40f00e..e105feb4e82 100644 --- a/registration/include/pcl/registration/impl/ia_fpcs.hpp +++ b/registration/include/pcl/registration/impl/ia_fpcs.hpp @@ -231,7 +231,7 @@ pcl::registration::FPCSInitialAlignment bool pcl::registration::FPCSInitialAlignment ::initCompute () { - std::srand (static_cast (std::time (NULL))); + std::srand (static_cast (std::time (nullptr))); // basic pcl initialization if (!pcl::PCLBase ::initCompute ()) diff --git a/registration/include/pcl/registration/impl/ia_ransac.hpp b/registration/include/pcl/registration/impl/ia_ransac.hpp index 3d618bc90cb..603a61204b3 100644 --- a/registration/include/pcl/registration/impl/ia_ransac.hpp +++ b/registration/include/pcl/registration/impl/ia_ransac.hpp @@ -47,7 +47,7 @@ template void pcl::SampleConsensusInitialAlignment::setSourceFeatures (const FeatureCloudConstPtr &features) { - if (features == NULL || features->empty ()) + if (features == nullptr || features->empty ()) { PCL_ERROR ("[pcl::%s::setSourceFeatures] Invalid or empty point cloud dataset given!\n", getClassName ().c_str ()); return; @@ -59,7 +59,7 @@ pcl::SampleConsensusInitialAlignment::setSou template void pcl::SampleConsensusInitialAlignment::setTargetFeatures (const FeatureCloudConstPtr &features) { - if (features == NULL || features->empty ()) + if (features == nullptr || features->empty ()) { PCL_ERROR ("[pcl::%s::setTargetFeatures] Invalid or empty point cloud dataset given!\n", getClassName ().c_str ()); return; diff --git a/registration/include/pcl/registration/impl/ndt.hpp b/registration/include/pcl/registration/impl/ndt.hpp index b9cde24775a..b3a51cb114d 100644 --- a/registration/include/pcl/registration/impl/ndt.hpp +++ b/registration/include/pcl/registration/impl/ndt.hpp @@ -153,7 +153,7 @@ pcl::NormalDistributionsTransform::computeTransformati p = p + delta_p; // Update Visualizer (untested) - if (update_visualizer_ != 0) + if (!update_visualizer_.empty()) update_visualizer_ (output, std::vector(), *target_, std::vector() ); double cos_angle = 0.5 * (transformation_.coeff (0, 0) + transformation_.coeff (1, 1) + transformation_.coeff (2, 2) - 1); diff --git a/registration/include/pcl/registration/impl/ndt_2d.hpp b/registration/include/pcl/registration/impl/ndt_2d.hpp index daecb23271c..98c05a42c48 100644 --- a/registration/include/pcl/registration/impl/ndt_2d.hpp +++ b/registration/include/pcl/registration/impl/ndt_2d.hpp @@ -280,7 +280,7 @@ namespace pcl Eigen::Vector2i idxi = idxf.cast (); for (size_t i = 0; i < 2; i++) if (idxi[i] >= cells_[i] || idxi[i] < 0) - return NULL; + return nullptr; // const cast to avoid duplicating this function in const and // non-const variants... return const_cast (&normal_distributions_.coeffRef (idxi[0], idxi[1])); @@ -469,7 +469,7 @@ pcl::NormalDistributionsTransform2D::computeTransforma nr_iterations_++; - if (update_visualizer_ != 0) + if (!update_visualizer_.empty()) update_visualizer_ (output, *indices_, *target_, *indices_); //std::cout << "eps=" << fabs ((transformation - previous_transformation_).sum ()) << std::endl; diff --git a/registration/include/pcl/registration/impl/sample_consensus_prerejective.hpp b/registration/include/pcl/registration/impl/sample_consensus_prerejective.hpp index c0c5d6b95a4..94f7b34f463 100644 --- a/registration/include/pcl/registration/impl/sample_consensus_prerejective.hpp +++ b/registration/include/pcl/registration/impl/sample_consensus_prerejective.hpp @@ -45,7 +45,7 @@ template void pcl::SampleConsensusPrerejective::setSourceFeatures (const FeatureCloudConstPtr &features) { - if (features == NULL || features->empty ()) + if (features == nullptr || features->empty ()) { PCL_ERROR ("[pcl::%s::setSourceFeatures] Invalid or empty point cloud dataset given!\n", getClassName ().c_str ()); return; @@ -57,7 +57,7 @@ pcl::SampleConsensusPrerejective::setSourceF template void pcl::SampleConsensusPrerejective::setTargetFeatures (const FeatureCloudConstPtr &features) { - if (features == NULL || features->empty ()) + if (features == nullptr || features->empty ()) { PCL_ERROR ("[pcl::%s::setTargetFeatures] Invalid or empty point cloud dataset given!\n", getClassName ().c_str ()); return; diff --git a/registration/include/pcl/registration/impl/transformation_estimation_lm.hpp b/registration/include/pcl/registration/impl/transformation_estimation_lm.hpp index c857342e903..49131754e98 100644 --- a/registration/include/pcl/registration/impl/transformation_estimation_lm.hpp +++ b/registration/include/pcl/registration/impl/transformation_estimation_lm.hpp @@ -107,8 +107,8 @@ pcl::registration::TransformationEstimationLMsetParam (x); transformation_matrix = warp_point_->getTransform (); - tmp_src_ = NULL; - tmp_tgt_ = NULL; + tmp_src_ = nullptr; + tmp_tgt_ = nullptr; } ////////////////////////////////////////////////////////////////////////////////////////////// @@ -187,9 +187,9 @@ pcl::registration::TransformationEstimationLMsetParam (x); transformation_matrix = warp_point_->getTransform (); - tmp_src_ = NULL; - tmp_tgt_ = NULL; - tmp_idx_src_ = tmp_idx_tgt_ = NULL; + tmp_src_ = nullptr; + tmp_tgt_ = nullptr; + tmp_idx_src_ = tmp_idx_tgt_ = nullptr; } ////////////////////////////////////////////////////////////////////////////////////////////// diff --git a/registration/include/pcl/registration/registration.h b/registration/include/pcl/registration/registration.h index 9e693609315..cf04b7c6d80 100644 --- a/registration/include/pcl/registration/registration.h +++ b/registration/include/pcl/registration/registration.h @@ -372,7 +372,7 @@ namespace pcl template inline bool registerVisualizationCallback (boost::function &visualizerCallback) { - if (visualizerCallback != NULL) + if (!visualizerCallback.empty()) { update_visualizer_ = visualizerCallback; return (true);