Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] artifact downloads only work for signed in users #5465

Closed
ashtro-0 opened this issue May 18, 2024 · 2 comments
Closed

[BUG] artifact downloads only work for signed in users #5465

ashtro-0 opened this issue May 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ashtro-0
Copy link

Describe the bug

I am unable to download jdk21 on my phone because I'm not signed in there and it would be inconvenient to do so especially for users without any need for accounts

The log file and images/videos

404 not found

Steps To Reproduce

make sure you're not signed into github then go to https://github.com/PojavLauncherTeam/android-openjdk-build-multiarch/actions/runs/8805754633 and try to download from artifacts

Expected Behavior

regardless of whether a user is signed in or not, the downloads should work

Platform

- Device model: 
- CPU architecture: aarch64
- Android version: 12
- PojavLauncher version:

Anything else?

further discussion: actions/upload-artifact#51
possible solution: actions/upload-artifact#51 (comment)

@ashtro-0 ashtro-0 added the bug Something isn't working label May 18, 2024
@kasrarouhi
Copy link

kasrarouhi commented May 18, 2024

Frist don't download jdk download jre file. Jre have necessary feature to run a java app but jdk have unnecessary features you don't need jdk and you need to register to download pojav launcher GitHub versions and java versions need to login or register to download. GitHub is trusted website

@ashtro-0
Copy link
Author

ah right, security and convenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants