Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sprite URLs #736

Closed
marko-knoebl opened this issue Jul 22, 2022 · 8 comments
Closed

Incorrect sprite URLs #736

marko-knoebl opened this issue Jul 22, 2022 · 8 comments
Labels

Comments

@marko-knoebl
Copy link

If I access

https://pokeapi.co/api/v2/pokemon/1

the value of sprites.front_default is:

https://raw.githubusercontent.com/PokeAPI/sprites/master/https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

  • which is not a valid image URL - a correct value would be:

https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

Looking at some code examples / demos that are using this API, they are all not showing images anymore at the moment

A couple of hours ago, images were still working for me

@mertthesamael
Copy link

Same here, i thought my code just blown up

@igordeoliveira95
Copy link

The moment I deployed my personal project this occurs haha, waiting for fixes.

@Naramsim
Copy link
Member

Naramsim commented Jul 22, 2022

Hi all, I'm really sorry for the problem. I rolled back and purged the Cloudflare cache. Thanks for raising the issue

@marko-knoebl
Copy link
Author

Thanks for the quick fix! Everything seems to be working again from my POV

@Naramsim
Copy link
Member

Hi, this isn't a fix, just a roll back. This is the PR (#727) that broke the sprites.

I think we add the duplicated https://raw.githubusercontent.com/PokeAPI/sprites/master/ not in the build phase, but in Ditto or something. I'll investigate next Monday.

@C-Garza
Copy link
Member

C-Garza commented Nov 11, 2022

Was this issue resolved in #745 @Naramsim?

@jayk-gupta
Copy link

If I access

https://pokeapi.co/api/v2/pokemon/1

the value of sprites.front_default is:

https://raw.githubusercontent.com/PokeAPI/sprites/master/https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

  • which is not a valid image URL - a correct value would be:

https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/1.png

Looking at some code examples / demos that are using this API, they are all not showing images anymore at the moment

A couple of hours ago, images were still working for me

Not working

@Naramsim
Copy link
Member

Naramsim commented Jan 7, 2023

@Naramsim Naramsim closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants