From fdcbd7644543c9b2b719fd1ab115f3225313d0d3 Mon Sep 17 00:00:00 2001 From: DeXtroTip Date: Wed, 31 Aug 2016 00:44:24 +0100 Subject: [PATCH 1/2] Fixed egg hatching data * Need of api call to update inventory when an egg hatchs to be able to encounter the pokemon that hatched * Reverted/removed 'except IndexError', not needed now --- pokemongo_bot/cell_workers/incubate_eggs.py | 30 ++++++++++----------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/pokemongo_bot/cell_workers/incubate_eggs.py b/pokemongo_bot/cell_workers/incubate_eggs.py index 7dc1b63619..004cc4277f 100644 --- a/pokemongo_bot/cell_workers/incubate_eggs.py +++ b/pokemongo_bot/cell_workers/incubate_eggs.py @@ -124,7 +124,8 @@ def _apply_incubators(self, available_eggs, available_incubators): egg["used"] = True def _check_inventory(self, lookup_ids=[]): - inv = {} + if lookup_ids: + inventory.refresh_inventory() matched_pokemon = [] temp_eggs = [] temp_used_incubators = [] @@ -212,21 +213,18 @@ def _hatch_eggs(self): pokemon['name'] = "error" except: pokemon_data = [{"name":"error", "cp":"error", "iv":"error"}] - try: - if not pokemon_ids or pokemon_data[0]['name'] == "error": - self.emit_event( - 'egg_hatched', - data={ - 'pokemon': 'error', - 'cp': 'error', - 'iv': 'error', - 'exp': 'error', - 'stardust': 'error', - 'candy': 'error', - } - ) - return - except IndexError: + if not pokemon_ids or pokemon_data[0]['name'] == "error": + self.emit_event( + 'egg_hatched', + data={ + 'pokemon': 'error', + 'cp': 'error', + 'iv': 'error', + 'exp': 'error', + 'stardust': 'error', + 'candy': 'error', + } + ) return for i in range(len(pokemon_data)): msg = "Egg hatched with a {pokemon} (CP {cp} - IV {iv}), {exp} exp, {stardust} stardust and {candy} candies." From b74dd5ebe24be96691687de0e3ffa9cf1acdda03 Mon Sep 17 00:00:00 2001 From: DeXtroTip Date: Wed, 31 Aug 2016 00:46:44 +0100 Subject: [PATCH 2/2] Small update --- pokemongo_bot/cell_workers/incubate_eggs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pokemongo_bot/cell_workers/incubate_eggs.py b/pokemongo_bot/cell_workers/incubate_eggs.py index 004cc4277f..9cc570b51e 100644 --- a/pokemongo_bot/cell_workers/incubate_eggs.py +++ b/pokemongo_bot/cell_workers/incubate_eggs.py @@ -213,7 +213,7 @@ def _hatch_eggs(self): pokemon['name'] = "error" except: pokemon_data = [{"name":"error", "cp":"error", "iv":"error"}] - if not pokemon_ids or pokemon_data[0]['name'] == "error": + if not pokemon_ids or not pokemon_data or pokemon_data[0]['name'] == "error": self.emit_event( 'egg_hatched', data={