Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Prevent release of bulk-evolvable pokemon (config) #1972

Closed
HecticSeptic opened this issue Jul 31, 2016 · 1 comment
Closed

Comments

@HecticSeptic
Copy link

HecticSeptic commented Jul 31, 2016

Desired Behavior

Keep only just enough (e.g.) Pidgeys for a batch evolve:

If the total candies needed to evolve all pokemon 'x' is less than held x candies, then do not release any pokemon x - because we want more of x for the next [manual] xp egg pop and batch evolve
If we have more Pidgeys than we have (Pidgey candies /12), we can then use normal release logic

pseudocode example:
candiesPerEvolve = 12 ## in the most important cases
...
if (keepEvolvable)
if (candiesPerEvolve * count(bot.getPokemon("Pidgey")) < bot.getCandies("Pidgey"))
release = False
...

Actual Behavior

No apparent way to keep a good number of pidgeys, caterpies and weedles for batch evolve. Setting keep_best_cp (and or IV) too high just results in a full box/inventory (and error).

Steps to Reproduce

Add keepEvolvable flag to release config in json file.
Handle unset or mistyped flags.
Change transfer_pokemon.py to cancel any release which would reduce batch evolves if flag is true

Future addition: if evolve is set in config, only do so once pokemon inventory fills up, that way the max batch evolve output can be reached with the xp egg
Potential max: if using 20s evolves, only 30 are needed, could have
"Pidgey,Weedle,Caterpie": {"keep_best_cp": 30, "keepEvolvable": True}
// (i.e. all three together total 30 and can all evolve)

Other Information

OS: Should be independent
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here) N/A

@HecticSeptic
Copy link
Author

#1973 suggests the same feature, within seconds of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants