Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Advanced Config: Release #2381

Closed
mjmadsen opened this issue Aug 2, 2016 · 2 comments
Closed

[dev] Advanced Config: Release #2381

mjmadsen opened this issue Aug 2, 2016 · 2 comments

Comments

@mjmadsen
Copy link
Contributor

mjmadsen commented Aug 2, 2016

Expected Behavior

Only print transfer list when we have some to transfer.
Only transfer when criteria is met.

Actual Behavior

[13:31:30] Keep 5 best Drowzee, based on cp
[13:31:30] Drowzee [CP 687] [Potential 0.71]
[13:31:30] Drowzee [CP 679] [Potential 0.58]
[13:31:30] Drowzee [CP 675] [Potential 0.62]
[13:31:30] Drowzee [CP 664] [Potential 0.8]
[13:31:30] Drowzee [CP 622] [Potential 0.64]
[13:31:30] Transferring 0 Drowzee
[13:31:30] Transferring 1 Magikarp
[13:31:30] Exchanging Magikarp [CP 10] [Potential 0.8] for candy!
[13:31:33] Transferring 1 Bellsprout
[13:31:33] Exchanging Bellsprout [CP 104] [Potential 0.53] for candy!
[13:31:37] Transferring 1 Exeggcute
[13:31:37] Exchanging Exeggcute [CP 459] [Potential 0.6] for candy!

Steps to Reproduce

"release": {
  "Exeggcute": {"release_below_cp": 371},
  "Drowzee": {"keep_best_cp": 10}, 
  "any": {"keep_best_cp": 3}

This is only a portion of my release config. There are many other defined similarly to "Exeggucte" and "Drowzee" above. I'm trying to keep the best X for common that I plan to evolve for EXP, limit kept pokemon to CP levels that will evolve above 1k and keep the top three for any pokemon not explicitly stated in the config.

@mjmadsen
Copy link
Contributor Author

mjmadsen commented Aug 2, 2016

The Drowzee issue there is related to #2382. Currently not an issue with new dev commit.

Removed the "any" portion and now no pokemon with "release_below_cp" set are released. Keep_best_cp is working properly, however.

@mjmadsen
Copy link
Contributor Author

mjmadsen commented Aug 2, 2016

Related to #2200.

You must specify both CP and IV. The following worked:

"Exeggcute": {"release_below_cp": 371, "release_below_iv": 0.1, "logic": "or"},

@mjmadsen mjmadsen closed this as completed Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants