Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Check That Pokemon Storage Is Full Before EvolvePokemon Action #2931

Closed
JonnyBoy333 opened this issue Aug 7, 2016 · 4 comments

Comments

@JonnyBoy333
Copy link

It would be nice to put a condition on the EvolvePokemon action to only run when the pokemon storage is full. Something like this:

        {
            "type": "EvolvePokemon",
            "config": {
                "evolve_when_storage_full": true,
                "evolve_all": "Pidgey, Weedle, Caterpie",
                "first_evolve_by": "cp"
            }
        }
@julienlavergne
Copy link
Contributor

You can try out my pull request and give me your comments about it.
#2956

@JonnyBoy333
Copy link
Author

This looks promising. Can you update the config file with an example of the new task and it's parameters?

@k4n30
Copy link
Contributor

k4n30 commented Aug 14, 2016

@JonnyBoy333 can this be closed now that the PR has been merged?

@JonnyBoy333
Copy link
Author

I'd say so. Just updated to the latest commit so I'm eagerly testing the new feature out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants