Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confusing words] Fled vs Escape #3117

Closed
DeviousFusion opened this issue Aug 8, 2016 · 5 comments
Closed

[Confusing words] Fled vs Escape #3117

DeviousFusion opened this issue Aug 8, 2016 · 5 comments

Comments

@DeviousFusion
Copy link
Contributor

DeviousFusion commented Aug 8, 2016

Pull #3118

Expected Behavior

[pokemon_escaped] Eevee escaped.

Actual Behavior

[pokemon_fled] Eevee fled.

Steps to Reproduce

Run the bot as usual. Whenever a pokemon escapes from pokeball, the word usage is confusing

Other Information

OS:
Git Commit: ff380cd
Python Version: Python 2.7.12

@fe-ax
Copy link

fe-ax commented Aug 8, 2016

This is wrong. You can't just rename the event, please revert.

@fe-ax
Copy link

fe-ax commented Aug 8, 2016

pokemongo_bot.event_manager.EventNotRegisteredException: Event pokemon_escaped not registered...

@DeviousFusion
Copy link
Contributor Author

@marco208 : Fixing. I forgot to push init.py

@fe-ax
Copy link

fe-ax commented Aug 8, 2016

Thanks for your contributions :)

@RedViper9
Copy link
Contributor

RedViper9 commented Aug 8, 2016

Thanks for noting this! I had thought the bot was just forcing the api to catch fled pokemon!

2016-08-08 12:23:46,353 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Greatball, with chance 46.80 (52 left)
2016-08-08 12:23:47,738 [PokemonCatchWorker] [INFO] [pokemon_fled] Psyduck fled.
2016-08-08 12:23:49,401 [PokemonCatchWorker] [INFO] [threw_pokeball] Used Greatball, with chance 46.80 (51 left)
2016-08-08 12:23:50,754 [PokemonCatchWorker] [INFO] [pokemon_caught] Captured Psyduck! [CP 495] [Potential 0.18] [2/0/6] [+150 exp]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants