Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!dev - threshold recycle items infinite loop #3279

Closed
Philipp59 opened this issue Aug 9, 2016 · 2 comments
Closed

!dev - threshold recycle items infinite loop #3279

Philipp59 opened this issue Aug 9, 2016 · 2 comments

Comments

@Philipp59
Copy link

Philipp59 commented Aug 9, 2016 •
edited
Loading

starting the bot with threshold config
using 59f55fd

2016-08-09 14:42:38,638 [PokemonGoBot] [INFO] 
2016-08-09 14:42:40,108 [PokemonGoBot] [INFO] [bot_start] Starting bot...
2016-08-09 14:42:40,730 [CollectLevelUpReward] [INFO] [level_up_reward] Received level up reward: []
2016-08-09 14:42:40,731 [IncubateEggs] [INFO] [next_egg_incubates] Next egg incubates in 1.10 km
2016-08-09 14:42:40,732 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:41,241 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:41,767 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:42,300 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:42,806 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:43,361 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:44,242 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:45,192 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:45,706 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:46,250 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:46,790 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:47,309 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:47,919 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:48,425 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:48,939 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:49,462 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:49,965 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:50,880 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:51,614 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:52,118 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:52,670 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:53,168 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:53,682 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:54,197 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:55,154 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:55,732 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:56,727 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:57,260 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:57,787 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:58,582 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:59,120 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:42:59,650 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:00,160 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:00,690 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:01,257 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:02,239 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:02,819 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:03,374 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:03,884 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:04,406 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:04,913 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:05,602 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:06,115 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:06,637 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:07,159 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:08,206 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:08,742 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:09,290 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:09,865 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:10,367 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:10,892 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:11,397 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:11,905 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:12,438 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:12,946 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:13,886 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:14,421 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:15,095 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
2016-08-09 14:43:15,633 [RecycleItems] [INFO] [item_discard_skipped] Skipping Recycling of Items. 52 space left in bag.
@Philipp59 Philipp59 changed the title dev - threshold !dev - threshold Aug 9, 2016
@Philipp59 Philipp59 changed the title !dev - threshold !dev - threshold recycle items infinite loop Aug 9, 2016
@Philipp59 Philipp59 mentioned this issue Aug 10, 2016
Closed
@Setsu-BHMT
Copy link

Setsu-BHMT commented Aug 10, 2016 •
edited
Loading

This is a bug in recycle_items.py line 30:
if free_bag_space >= self.min_empty_space:

The greater than or equals check should actually be less than or equals; the way it is coded now causes it to skip recycling if any minimum space is defined.
Short term solution: remove min_empty_space definition from config.

EDIT: actually, my bad, I misread the intention of this setting.
I originally thought this is meant to keep a minimum amount of empty space in your inventory, but the actual intention was to avoid recycling until the minimum empty space limit is exceeded. As such, the behavior is by design and not a bug, but the logging should be reduced or even removed.

@Ph4i1ur3 Ph4i1ur3 mentioned this issue Aug 10, 2016
Closed
@k4n30
Copy link
Contributor

k4n30 commented Aug 16, 2016

New update has better inventory management

@k4n30 k4n30 closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k4n30 @Setsu-BHMT @Philipp59