Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect candy count displayed via Command Line #3619

Closed
andrew-tjz opened this issue Aug 11, 2016 · 6 comments
Closed

Incorrect candy count displayed via Command Line #3619

andrew-tjz opened this issue Aug 11, 2016 · 6 comments

Comments

@andrew-tjz
Copy link

Stop! Before you create this issue (you can delete this section when opening the issue):

  1. Have you validated that your config.json is valid JSON? Use http://jsonlint.com/ to check.
  2. Have you searched to see if there are other issues for the same issue? If so, comment on that issue instead.
  3. Are you running master? We work on the dev branch and then add that functionality to master. Your issue may be fixed on dev and there is no need for this issue, just wait and it will eventually be merged to master.

Expected Behavior

2016-08-11 10:36:10,292 [PokemonCatchWorker] [INFO] [gained_candy] You now have x_number Dratini candy!

Actual Behavior

2016-08-11 10:36:10,292 [PokemonCatchWorker] [INFO] [gained_candy] You now have 3 Dragonair candy!

Count always stays at 3.

Your config.json (remove your credentials and any other private info)

    "tasks":
    [
        {
            "type": "HandleSoftBan"
        },
        {
            "type": "CollectLevelUpReward"
        },
        {
            "type": "IncubateEggs",
            "config":
            {
                "longer_eggs_first": true
            }
        },
        {
            "type": "NicknamePokemon",
            "config":
            {
                "nickname_template": "{iv_pct}_{name:.8s}"
            }
        },
        {
            "type": "TransferPokemon"
        },
        {
            "type": "EvolvePokemon",
            "config":
            {
                "evolve_all": "Pidgey,Rattata,Weedle,Zubat,Spearow,Caterpie",
                "first_evolve_by": "cp",
                "// evolve_above_cp": 500,
                "// evolve_above_iv": 0.8,
                "logic": "or",
                "evolve_speed": 20,
                "use_lucky_egg": false
            }
        },
        {
            "type": "RecycleItems",
            "config":
            {
                "item_filter":
                {
                    "Pokeball":       { "keep" : 10 },
                    "Greatball":      { "keep" : 20 },
                    "Ultraball":      { "keep" : 70 },
                    "Potion":         { "keep" : 1 },
                    "Super Potion":   { "keep" : 1 },
                    "Hyper Potion":   { "keep" : 10 },
                    "Revive":         { "keep" : 10 },
                    "Razz Berry":     { "keep" : 100 }
                }
            }
        },
        {
            "type": "CatchVisiblePokemon"
        },
        {
            "type": "CatchLuredPokemon"
        },
        {
            "type": "SpinFort"
        },
        {
            "type": "MoveToFort",
            "config":
            {
                "lure_attraction": true,
                "lure_max_distance": 2000
            }
        },
        {
            "type": "FollowSpiral",
            "config":
            {
                "diameter": 4,
                "step_size": 70
            }
        }
    ],
    "map_object_cache_time": 5,
    "forts":
    {
        "avoid_circles": true,
        "max_circle_size": 50
    },
    "websocket_server": false,
    "walk": 4.16,
    "action_wait_min": 1,
    "action_wait_max": 4,
    "debug": false,
    "test": false,
    "health_record": true,
    "location_cache": true,
    "distance_unit": "km",
    "reconnecting_timeout": 15,
    "evolve_captured": "NONE",
    "catch_randomize_reticle_factor": 1.0,
    "catch_randomize_spin_factor": 1.0,
    "catch":
    {
        "any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"},
        "// Example of always catching Rattata:": {},
        "// Rattata": { "always_catch" : true }
    },
    "release":
    {
        "any": {"keep_best_cp": 2},
        "// any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"},
        "// Example of always releasing Rattata:": {},
        "// Rattata": {"always_release": true},
        "// Example of keeping 3 stronger (based on CP) Pidgey:": {},
        "// Pidgey": {"keep_best_cp": 3},
        "// Example of keeping 2 stronger (based on IV) Zubat:": {},
        "// Zubat": {"keep_best_iv": 2},
        "// Also, it is working with any": {},
        "// any": {"keep_best_iv": 3},
        "// Example of keeping the 2 strongest (based on CP) and 3 best (based on IV) Zubat:": {},
        "// Zubat": {"keep_best_cp": 2, "keep_best_iv": 3}
    },
    "vips" :
    {
        "Any pokemon put here directly force to use Berry & Best Ball to capture, to secure the capture rate!": {},
        "any": {"catch_above_cp": 1200, "catch_above_iv": 0.9, "logic": "or" },
        "Lapras": {},
        "Moltres": {},
        "Zapdos": {},
        "Articuno": {},
        "// S-Tier pokemons (if pokemon can be evolved into tier, list the representative)": {},
        "Mewtwo": {},
        "Dragonite": {},
        "Snorlax": {},
        "// Mew evolves to Mewtwo": {},
        "Mew": {},
        "Arcanine": {},
        "Vaporeon": {},
        "Gyarados": {},
        "Exeggutor": {},
        "Muk": {},
        "Weezing": {},
        "Flareon": {},
        "Scyther": {},
        "Blastoise": {}
    }
}

Steps to Reproduce

Capture a Dragonair!

Other Information

OS: Windows 10
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here): 63f777b
Python Version: (run 'python -V' and paste it here): Python 2.7.12

@k4n30
Copy link
Contributor

k4n30 commented Aug 11, 2016

Can you update to the latest version and try again. If the issue persists, please capture more logs, i.e show multiple Pokemon with the 3 candy bug as your output says 3 Dragonair candy when it should be Dratini so we need to isolate it to the Dratini/Dragonair/Dragonite family or a wider issue

@andrew-tjz
Copy link
Author

I will get the latest code tonight and retry for you.

It only seems to be for Dragonair since all of the others worked fine. Golbat gave me Zubat candy, Hypno gave me Drowzee candy, etc...

I only noticed it because it said Dragonair candy instead of Dratini candy and the count is always 3.

Also, I just checked via my phone and it says 48 Candy so it looks like it's just an incorrect report on the command line.

@andrew-tjz
Copy link
Author

That is exactly the problem. It should be saying total number of Dratini candy. Instead, it says 3 Dragonair candy every time you capture a Dragonair.

It's really not a big deal since it shows up fine when you login via a phone.

@andrew-tjz
Copy link
Author

Alright no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@k4n30 @andrew-tjz and others