Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep best 2 attack pokemon #4084

Closed
Tagada22 opened this issue Aug 16, 2016 · 7 comments
Closed

Keep best 2 attack pokemon #4084

Tagada22 opened this issue Aug 16, 2016 · 7 comments

Comments

@Tagada22
Copy link

Hello

Its possible to keep pokemon with the bestet attack

Exemple :

Dragonite :

Dragon claw : 35
Dragon : dragon pulse : 65

Transfert pokemon

Dragon claw : 35

Hyper beam : 120

Keep pokemon

http://www.pokemongodb.net/2016/05/dragonite.html?m=1

Combined this setting and iv 100% we can have the most powerful pokemon.

Maybe options is already implanted or next feature ?

@julienlavergne
Copy link
Contributor

You can use "dps" as a sorting order in Pokemon optimizer. Check if it fits your need.

@k4n30
Copy link
Contributor

k4n30 commented Aug 17, 2016

What determines the best attack in your mind @Tagada22 ? DPS as Anakin mention, or highest number is best?

@tolinwei
Copy link

Gym fighting is not just a matter of attack value, some secondary moves have longer "Dodge Window", that allows players to dodge the still easier; some moves have lower attack value but higher DPS, which generates more damage.
Check out the link here: https://pokemongo.gamepress.gg/pokemon/149
For Dragonite, Dragon Claw has lowest "attack value" - 35, but it has hightest DPS, which is the best for attacking.

@Foulwerp
Copy link

Foulwerp commented Aug 17, 2016

You can use dps_defense and dps_attack not sure how accurately these are calculated though.

dps_defense I believe would be the best for defending a gym, and the other is attacking a gym.

I think the AI for gym defense needs a rework, Since they don't dodge and can attack only every 2 seconds makes most gyms with enough time a push over.

                if keep_best_dps >= 1:
                    dps_limit = keep_best_dps
                    best_dps_pokemons = sorted(group, key=lambda x: (x.moveset.dps, x.iv, x.cp), reverse=True)[:dps_limit]
                    best_pokemon_ids |= set(pokemon.id for pokemon in best_dps_pokemons)
                    order_criteria = 'Moveset DPS'   

                if keep_best_dps_defense >= 1:
                    dps_limit = keep_best_dps_defense
                    best_dps_pokemons = sorted(group, key=lambda x: (x.moveset.dps_defense, x.iv, x.cp), reverse=True)[:dps_limit]
                    best_pokemon_ids |= set(pokemon.id for pokemon in best_dps_pokemons)
                    order_criteria = 'Defensive Moveset DPS'   

                if keep_best_dps_attack >= 1:
                    dps_limit = keep_best_dps_attack
                    best_dps_pokemons = sorted(group, key=lambda x: (x.moveset.dps_attack, x.iv, x.cp), reverse=True)[:dps_limit]
                    best_pokemon_ids |= set(pokemon.id for pokemon in best_dps_pokemons)
                    order_criteria = 'Offensive Moveset DPS'

Not sure how well this would work.

I don't know python very well but if you could define the key to sort by in the config for each pokemon then use that key it could be neat.

For example...

"Charmander": { 
    "keep_best_custom": "dps_attack,iv,cp", 
    "amount": 2
}

@supercourgette
Copy link
Contributor

supercourgette commented Aug 18, 2016

On the dev branch, you can now keep your Pokemons according to a selection of your own criteria among: 'cp','iv', 'iv_attack', 'iv_defense', 'iv_stamina', 'moveset.attack_perfection', 'moveset.defense_perfection', 'hp', 'hp_max'. Check the docs and let me know if (1) it's working and (2) answer your question. ;)

@supercourgette
Copy link
Contributor

I'm not sure if this is exactly Tagada22 asked for since this feature haven't been tested by users yet and I'm a bit confuse about the meaning of moveset.defense_perfection and moveset.attack_perfection.

@k4n30
Copy link
Contributor

k4n30 commented Aug 18, 2016

@Tagada22 Can you review latest dev and see if it meets your needs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@k4n30 @tolinwei @supercourgette @Foulwerp @julienlavergne @Tagada22 and others