Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PokemonCatchWorker catch condition not working properly #5199

Closed
xivaxy opened this issue Sep 5, 2016 · 0 comments
Closed

PokemonCatchWorker catch condition not working properly #5199

xivaxy opened this issue Sep 5, 2016 · 0 comments
Labels

Comments

@xivaxy
Copy link

xivaxy commented Sep 5, 2016

Expected Behavior

Pokemons are caught based on candy_threshold and catch_above_cp conditions.

Actual Behavior

Often the pokemons satisfying the catch condition are ignored.

Example 1
config.json:
"catch": {
"any": {"candy_threshold" : 400 ,"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"},
"Pidgey": {"candy_threshold": 180},
...
"release": {
"any": {"keep_best_cp": 2},
"Pidgey": {"keep_best_cp": 30},
...

Start bot:
...
[PokemonGoBot] [INFO] #16 Pidgey[20][150 candies]: (CP 77 ...
...
[PokemonCatchWorker] [INFO] Skip ignored Pidgey! [CP 23]
...

Example 2:
config.json:
"catch": {
"any": {"candy_threshold" : 400 ,"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"},
"Pidgey": {"catch_above_cp": 20},
...
"release": {
"any": {"keep_best_cp": 2},
"Pidgey": {"keep_best_cp": 30},
...

Start bot:
...
[PokemonCatchWorker] [INFO] Skip ignored Pidgey! [CP 23] [
...

When I comment out the Pidgey catch condition ("// Pidgey": {"catch_above_cp": 20}, ), the bot starts catching them.
Similar things happens at least with Spearow, Meowth, Magmar.

Your FULL config.json (remove your username, password, gmapkey and any other private info)

http://pastebin.com/nkjH8U9T

Other Information

OS:
Win8
Branch:
dev
Git Commit:
ddc731d
Python Version:
2.7.12

@oralunal oralunal added the Bug label Sep 5, 2016
@k4n30 k4n30 closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants