-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WARNING: release logic issue. 5 Snorlax and 2 Lapras are released #5587
Comments
|
I know its a bit late now, but key ones I have favorited which means release does not touch them |
Oh hell, I'm on it. |
Oh... ok this is working as intended... ish. Your config should be "never_release": true, not "always_release": false. It still shouldn't release anything because there's no matching rule (and I'll provide a fix for that shortly), but fix your config to prevent reoccurrence. |
Also add an "any" rule in there to provide rules for anything you haven't specified... At the moment, it just assumes you want to release everything if you don't specify otherwise. Again, this is wrong, but until its fixed... |
PR #5596 has been merged to dev. Should fix. Let me know if any issues remaining. |
Thanks I changed to never_release |
dev:
I just did a git pull (last pull is 3 days ago),
OMG!!! some how the new release logic released my 5 Snorlax and 2 Lapras
[2016-09-21 00:25:42] Releasing Lapras CP: 2153, IV: 0.53, IVCP: 0.66 | based on rule: CP < 0 AND IV < 0 IVCP < 0
[2016-09-21 00:25:43] Released Lapras (CP: 2153, IV: 0.53, IVCP: 0.66) You now have 2 Lapras candies
[2016-09-21 00:25:47] Releasing Lapras CP: 1687, IV: 0.73, IVCP: 0.75 | based on rule: CP < 0 AND IV < 0 IVCP < 0
[2016-09-21 00:26:01] Releasing Snorlax CP: 1590, IV: 0.84, IVCP: 0.75 | based on rule: CP < 0 AND IV < 0 IVCP < 0
[2016-09-21 00:26:02] Released Snorlax (CP: 1590, IV: 0.84, IVCP: 0.75) You now have 8 Snorlax candies
[2016-09-21 00:26:06] Releasing Snorlax CP: 1393, IV: 0.82, IVCP: 0.84 | based on rule: CP < 0 AND IV < 0 IVCP < 0
[2016-09-21 00:26:07] Released Snorlax (CP: 1393, IV: 0.82, IVCP: 0.84) You now have 9 Snorlax candies
[2016-09-21 00:26:11] Releasing Snorlax CP: 323, IV: 0.93, IVCP: 0.95 | based on rule: CP < 0 AND IV < 0 IVCP < 0
[2016-09-21 00:26:11] Released Snorlax (CP: 323, IV: 0.93, IVCP: 0.95) You now have 10 Snorlax candies
[2016-09-21 00:26:14] Releasing Snorlax CP: 225, IV: 0.67, IVCP: 0.78 | based on rule: CP < 0 AND IV < 0 IVCP < 0
[2016-09-21 00:26:15] Released Snorlax (CP: 225, IV: 0.67, IVCP: 0.78) You now have 11 Snorlax candies
[2016-09-21 00:26:18] Releasing Snorlax CP: 42, IV: 0.69, IVCP: 0.73 | based on rule: CP < 0 AND IV < 0 IVCP < 0
[2016-09-21 00:26:19] Released Snorlax (CP: 42, IV: 0.69, IVCP: 0.73) You now have 12 Snorlax candies
The text was updated successfully, but these errors were encountered: