Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing line in the sentences vignette on dev-branch #17

Closed
ChristophLeonhardt opened this issue May 6, 2020 · 1 comment
Closed

Missing line in the sentences vignette on dev-branch #17

ChristophLeonhardt opened this issue May 6, 2020 · 1 comment

Comments

@ChristophLeonhardt
Copy link

In the sentences vignette on the dev-branch (https://github.com/PolMine/cwbtools/blob/dev/vignettes/sentences.Rmd), one line is missing in the recipe:

cpos <- seq.int(from = 0L, to = length(pos) - 1L)

should be included after

pos <- corpus("GERMAPARL") %>% 
  get_token_stream(p_attribute = "pos")

otherwise the split won't work afterwards.

@ablaette
Copy link
Collaborator

Many thanks for pointing out the issue and for offering a solution. Admittedly, the vignette was a draft rather than ready. The error you report should not have gone unnoticed ... Anyway, I reworked the code in the vignette so that it is a working example, I will push it right away to the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants