Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add mark project settled extrinsic #373

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Aug 6, 2024

What?

  • Add a new extrinsic which calls the already included do_mark_project_as_settled extrinsic

Why?

  • Any user should be able to transition the project from SettlementStarted to SettlementFinished. We need it for starting the migration

How?

  • Add an ensure_signed and a call to the do_ function

Testing?

  • new module for testing this extrinsic mark_project_as_settled_extrinsic in the next PR

@JuaniRios JuaniRios mentioned this pull request Aug 6, 2024
@JuaniRios JuaniRios changed the title add mark project settled extrinsic ✨ Add mark project settled extrinsic Aug 6, 2024
@JuaniRios JuaniRios self-assigned this Aug 6, 2024
@JuaniRios JuaniRios marked this pull request as ready for review August 6, 2024 15:00
@lrazovic lrazovic force-pushed the 08-06-add_mark_project_settled_extrinsic branch from 7b381ed to 87eeea2 Compare August 16, 2024 13:03
@lrazovic lrazovic mentioned this pull request Aug 16, 2024
@JuaniRios JuaniRios force-pushed the 08-06-add_mark_project_settled_extrinsic branch from 87eeea2 to 7b381ed Compare August 16, 2024 13:10
@lrazovic lrazovic force-pushed the 08-06-add_mark_project_settled_extrinsic branch from 7b381ed to 87eeea2 Compare August 16, 2024 13:13
@JuaniRios JuaniRios force-pushed the 08-06-add_mark_project_settled_extrinsic branch from 87eeea2 to 7b381ed Compare August 22, 2024 12:57
Copy link
Contributor Author

JuaniRios commented Aug 23, 2024

Merge activity

  • Aug 23, 5:56 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Aug 23, 6:33 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 23, 6:34 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 08-06-remove_random_end to graphite-base/373 August 23, 2024 10:28
@JuaniRios JuaniRios changed the base branch from graphite-base/373 to main August 23, 2024 10:31
@JuaniRios JuaniRios force-pushed the 08-06-add_mark_project_settled_extrinsic branch from 7b381ed to b9d98c6 Compare August 23, 2024 10:32
@JuaniRios JuaniRios merged commit 495cfc8 into main Aug 23, 2024
1 check passed
@JuaniRios JuaniRios deleted the 08-06-add_mark_project_settled_extrinsic branch August 23, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants