Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type declarations to all Polymer elements. #840

Closed
aomarks opened this issue Feb 2, 2018 · 8 comments
Closed

Add type declarations to all Polymer elements. #840

aomarks opened this issue Feb 2, 2018 · 8 comments

Comments

@aomarks
Copy link
Member

aomarks commented Feb 2, 2018

This issue is to track committing generated TypeScript type declarations into all of the Polymer element repos.

@aomarks aomarks self-assigned this Feb 2, 2018
@TimvdLippe
Copy link
Contributor

It appears that all PR's referenced in this issue have been merged. Has this task been completed? 🎉

@aomarks
Copy link
Member Author

aomarks commented Mar 13, 2018

These elements have typings merged but still need to be released (pending some testing):

  • PolymerElements/paper-radio-button
  • PolymerElements/paper-checkbox
  • PolymerElements/paper-dropdown-menu
  • PolymerElements/paper-tabs
  • PolymerElements/paper-radio-group
  • PolymerElements/app-layout (Compiles cleanly when _updateScrollState in app-scroll-effects-behavior has 1 argument srollTop of type number)
  • PolymerElements/paper-slider (Fixed: Incompatible typings in behaviors: IronRangeBehavior and IronFormElementBehavior declare different types for value)
  • PolymerElements/app-pouchdb (Fixed: Requires additional types from @types/pouchdb, which needs to custom installed. The reference in pouchdb.d.ts need to reference the npm package)
  • PolymerElements/test-fixture
  • PolymerElements/iron-component-page
  • PolymerElements/app-localize-behavior

These elements are still not quite compiling:

Everything else is merged and released.

@TimvdLippe
Copy link
Contributor

@aomarks I have updated your comment with several of my findings

@TimvdLippe
Copy link
Contributor

I have opened several other PRs to fix typings and updated the above comment with the reasons why some of them are still TODO. Getting closer and closer!

@kito99
Copy link
Contributor

kito99 commented Jun 6, 2018

So, what's the current status on this? How much has @aomarks Mar 13th update changed?

@aomarks
Copy link
Member Author

aomarks commented Aug 7, 2018

So, what's the current status on this? How much has @aomarks Mar 13th update changed?

Looks like it's now just app-media and test-fixture that don't have typings.

The next big task is support for the 3.0 version of elements. Those will come either with the final 3.0 releases, or shortly after.

@aomarks aomarks transferred this issue from Polymer/gen-typescript-declarations Jan 2, 2019
@stale
Copy link

stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 4, 2020
@stale
Copy link

stale bot commented Apr 29, 2022

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

@stale stale bot closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants