[docs] Draft events docs ready for review #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2019 13:01
ghost
requested a review
from 
ghost
changed the title
justinfagnani
approved these changes
Feb 4, 2019
|
|
||
| ### Where to add your event listeners | ||
|
|
||
| You need to add event listeners in a method that is guaranteed to fire before the event occurs. However, for optimal loading performance, you should add your event listener as late as possible. |
There was a problem hiding this comment.
Can we add a TODO to expand on why this is later? From this description it sounds like you should never add handlers in the template, but then that's the first thing we show. I think it's more subtle.
| } | ||
| ``` | ||
|
|
||
| ### Handle an event fired by a LitElement-based component {#handle-fired-event} |
There was a problem hiding this comment.
Since LitElement elements are the same as any other, do we really need this section?
There was a problem hiding this comment.
Added for completeness to address the use case in #473
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs work
staged https://20190108t174118-dot-polymer-lit-element.appspot.com/guide/events
fixes #371
fixes #139