Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn install --flat does not work in workspace testing #2733

Open
FredKSchott opened this issue Dec 19, 2017 · 2 comments
Open

yarn install --flat does not work in workspace testing #2733

FredKSchott opened this issue Dec 19, 2017 · 2 comments

Comments

@FredKSchott
Copy link
Contributor

There are a few issues uncovered with running yarn install --flat in a workspace:

  1. Yarn has a bug where the git hash of a locally referenced dependency (that's also been converted) is read as the package "version", causing errors inside of yarn ("83c19296e1cc615c224df685c497a8e5e38dcdf5 is not a valid version") .
  2. The new, desired post-conversion version is written to each package.json, which can cause conflicts when installing (ex: `can't flatten semver ranges "3.0.0-pre.1" & "3.0.0-pre.2").

Reverting to use npm install now, but we should fix this so that we have proper support for yarn.

@stramel
Copy link
Contributor

stramel commented Dec 19, 2017

Maybe this isn't the place to discuss this, but I'm curious if you guys are planning on moving forward with yarn or npm's asset module whenever it is finished?

@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants